From db74ef3d1acf99710eef9ccff9c3b6559c01a13d Mon Sep 17 00:00:00 2001 From: Fabien O'Carroll Date: Wed, 10 Apr 2019 17:05:11 +0200 Subject: [PATCH] Used return value of {set,remove}Cookie no-issue Soon these functions will make network calls, returning them allows us to use promises --- ghost/sdk/theme-dropin/src/index.js | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/ghost/sdk/theme-dropin/src/index.js b/ghost/sdk/theme-dropin/src/index.js index f5cc0a123c..165f8347ed 100644 --- a/ghost/sdk/theme-dropin/src/index.js +++ b/ghost/sdk/theme-dropin/src/index.js @@ -36,10 +36,12 @@ function setupMembersListeners() { const claims = getClaims(token); const expiry = new Date(claims.exp * 1000); document.cookie = 'member=' + token + ';Path=/;expires=' + expiry.toUTCString(); + return true; } function removeCookie() { document.cookie = 'member=null;Path=/;max-age=0'; + return true; } members.on('signedin', function () { @@ -65,8 +67,7 @@ function setupMembersListeners() { event.preventDefault(); members.signout() .then(() => { - removeCookie(); - return true; + return removeCookie(); }) .then(reload); } @@ -79,8 +80,7 @@ function setupMembersListeners() { audience: tokenAudience, fresh: true }).then(function (token) { - setCookie(token); - return true; + return setCookie(token); }); }) .then(reload); @@ -94,8 +94,7 @@ function setupMembersListeners() { audience: tokenAudience, fresh: true }).then(function (token) { - setCookie(token); - return true; + return setCookie(token); }); }) .then(reload);