Removed tag.parent from Admin API v2 response

refs #10438

- this is an unused field
- no need to expose this field
- if we start working on nested tags, this field might become interesting/used

core/server/api/v2/utils/serializers/output/utils/clean.js

@@ -1,12 +1,8 @@
 const _ = require('lodash');
 const localUtils = require('../../../index');
 
-const tag = (attrs) => {
+const tag = (attrs, frame) => {
-    // Already deleted in model.toJSON, but leaving here so that we can clean that up when we deprecate v0.1
+    if (localUtils.isContentAPI(frame)) {
-    delete attrs.parent_id;
-
-    // Extra properties removed from v2
-    delete attrs.parent;
         delete attrs.created_at;
         delete attrs.updated_at;
 
@@ -20,6 +16,13 @@ const tag = (attrs) => {
         if (attrs.description === '') {
             attrs.description = null;
         }
+    }
+
+    // Already deleted in model.toJSON, but leaving here so that we can clean that up when we deprecate v0.1
+    delete attrs.parent_id;
+
+    // Extra properties removed from v2
+    delete attrs.parent;
 
     return attrs;
 };

core/server/api/v2/utils/serializers/output/utils/mapper.js

@@ -21,10 +21,7 @@ const mapTag = (model, frame) => {
     const jsonModel = model.toJSON ? model.toJSON(frame.options) : model;
 
     url.forTag(model.id, jsonModel);
-
+    clean.tag(jsonModel, frame);
-    if (utils.isContentAPI(frame)) {
-        clean.tag(jsonModel);
-    }
 
     return jsonModel;
 };

core/test/acceptance/old/admin/utils.js

@@ -35,8 +35,8 @@ const expectedProperties = {
     ,
     tag: _(schema.tags)
         .keys()
-        // Tag API swaps parent_id to parent
+        // unused field
-        .without('parent_id').concat('parent')
+        .without('parent_id')
     ,
     setting: _(schema.settings)
         .keys()

core/test/regression/api/v2/admin/utils.js

@@ -32,8 +32,8 @@ const expectedProperties = {
     ,
     tag: _(schema.tags)
         .keys()
-        // Tag API swaps parent_id to parent
+        // unused field
-        .without('parent_id').concat('parent')
+        .without('parent_id')
     ,
     setting: _(schema.settings)
         .keys()