mirror of
https://github.com/TryGhost/Ghost.git
synced 2025-01-06 22:40:14 -05:00
Grouped "browse" unit tests together
refs https://linear.app/tryghost/issue/CORE-64/resolve-undissmissable-update-notification-banners - Before making changes + adding more tests to the notifications test suite grouped related "browse" tests into a describe block. Housekeeping :)
This commit is contained in:
Naz
parent
1249254a68
commit
d948be5bcb
1 changed files with 151 additions and 149 deletions
|
|
@ -6,155 +6,6 @@ const Notifications = require('../../../../../core/server/services/notifications
|
|||
const {owner} = require('../../../../utils/fixtures/context');
|
||||
|
||||
describe('Notifications Service', function () {
|
||||
it('can browse non-major version upgrade notifications', function () {
|
||||
const settingsCache = {
|
||||
get: sinon.fake.returns([{
|
||||
dismissible: true,
|
||||
id: '130f7c24-113a-4768-a698-12a8b34223f1',
|
||||
type: 'info',
|
||||
message: `<strong>Ghost 5.1.3 is now available</strong> - You are using an old version of Ghost, which means you don't have access to the latest features. <a href=\'https://ghost.org/changelog/4/\' target=\'_blank\' rel=\'noopener\'>Read more!</a>`,
|
||||
createdAt: '2021-03-16T12:55:20.000Z',
|
||||
addedAt: '2021-03-17T01:41:20.906Z'
|
||||
}])
|
||||
};
|
||||
|
||||
const notificationSvc = new Notifications({
|
||||
settingsCache,
|
||||
ghostVersion: {
|
||||
full: '4.1.0'
|
||||
}
|
||||
});
|
||||
|
||||
const notifications = notificationSvc.browse({user: owner});
|
||||
|
||||
should.exist(notifications);
|
||||
notifications.length.should.equal(1);
|
||||
});
|
||||
|
||||
it('can browse major version upgrade notifications', function () {
|
||||
const settingsCache = {
|
||||
get: sinon.fake.returns([{
|
||||
dismissible: true,
|
||||
location: 'bottom',
|
||||
status: 'alert',
|
||||
id: '130f7c24-113a-4768-a698-12a8b34223f6',
|
||||
custom: true,
|
||||
createdAt: '2021-03-16T12:55:20.000Z',
|
||||
type: 'info',
|
||||
top: true,
|
||||
message: `<strong>Ghost 5.0 is now available</strong> - You are using an old version of Ghost, which means you don't have access to the latest features. <a href=\'https://ghost.org/changelog/4/\' target=\'_blank\' rel=\'noopener\'>Read more!</a>`,
|
||||
seen: true,
|
||||
addedAt: '2021-03-17T01:41:20.906Z',
|
||||
seenBy: ['1']
|
||||
}])
|
||||
};
|
||||
|
||||
const notificationSvc = new Notifications({
|
||||
settingsCache,
|
||||
ghostVersion: {
|
||||
full: '4.0.0'
|
||||
}
|
||||
});
|
||||
|
||||
const notifications = notificationSvc.browse({user: owner});
|
||||
|
||||
should.exist(notifications);
|
||||
notifications.length.should.equal(1);
|
||||
});
|
||||
|
||||
it('cannot see 2.0 version upgrade notifications in Ghost 3.0', function () {
|
||||
const settingsCache = {
|
||||
get: sinon.fake.returns([{
|
||||
dismissible: true,
|
||||
location: 'bottom',
|
||||
status: 'alert',
|
||||
id: '130f7c24-113a-4768-a698-12a8b34223f7',
|
||||
custom: true,
|
||||
createdAt: '2020-03-16T12:55:20.000Z',
|
||||
type: 'info',
|
||||
top: true,
|
||||
message: `<strong>Ghost 2.0 is now available</strong> - You are using an old version of Ghost, which means you don't have access to the latest features.`,
|
||||
seen: true,
|
||||
addedAt: '2020-03-17T01:41:20.906Z',
|
||||
seenBy: ['1']
|
||||
}])
|
||||
};
|
||||
|
||||
const notificationSvc = new Notifications({
|
||||
settingsCache,
|
||||
ghostVersion: {
|
||||
full: '3.0.0'
|
||||
}
|
||||
});
|
||||
|
||||
const notifications = notificationSvc.browse({user: owner});
|
||||
|
||||
should.exist(notifications);
|
||||
notifications.length.should.equal(0);
|
||||
});
|
||||
|
||||
it('cannot see 4.0 version upgrade notifications in Ghost 4.0', function () {
|
||||
const settingsCache = {
|
||||
get: sinon.fake.returns([{
|
||||
dismissible: true,
|
||||
location: 'bottom',
|
||||
status: 'alert',
|
||||
id: '130f7c24-113a-4768-a698-12a8b34223f8',
|
||||
custom: true,
|
||||
createdAt: '2021-03-16T12:55:20.000Z',
|
||||
type: 'info',
|
||||
top: true,
|
||||
message: `<strong>Ghost 4.0 is now available</strong> - You are using an old version of Ghost, which means you don't have access to the latest features.`,
|
||||
seen: true,
|
||||
addedAt: '2021-03-17T01:41:20.906Z',
|
||||
seenBy: ['1']
|
||||
}])
|
||||
};
|
||||
|
||||
const notificationSvc = new Notifications({
|
||||
settingsCache,
|
||||
ghostVersion: {
|
||||
full: '4.0.0'
|
||||
}
|
||||
});
|
||||
|
||||
const notifications = notificationSvc.browse({user: owner});
|
||||
|
||||
should.exist(notifications);
|
||||
notifications.length.should.equal(0);
|
||||
});
|
||||
|
||||
it('cannot see 5.0 version upgrade notifications in Ghost 5.0', function () {
|
||||
const settingsCache = {
|
||||
get: sinon.fake.returns([{
|
||||
dismissible: true,
|
||||
location: 'bottom',
|
||||
status: 'alert',
|
||||
id: '130f7c24-113a-4768-a698-12a8b34223f9',
|
||||
custom: true,
|
||||
createdAt: '2022-03-16T12:55:20.000Z',
|
||||
type: 'info',
|
||||
top: true,
|
||||
message: `<strong>Ghost 5.0 is now available</strong> - You are using an old version of Ghost, which means you don't have access to the latest features.`,
|
||||
seen: true,
|
||||
addedAt: '2022-03-17T01:41:20.906Z',
|
||||
seenBy: ['1']
|
||||
}])
|
||||
};
|
||||
|
||||
const notificationSvc = new Notifications({
|
||||
settingsCache,
|
||||
ghostVersion: {
|
||||
full: '5.0.0'
|
||||
}
|
||||
});
|
||||
|
||||
const notifications = notificationSvc.browse({user: owner});
|
||||
|
||||
should.exist(notifications);
|
||||
notifications.length.should.equal(0);
|
||||
});
|
||||
|
||||
describe('add', function () {
|
||||
it('adds a single notification when no previous exist', function () {
|
||||
const existingNotifications = [];
|
||||
|
|
@ -198,6 +49,157 @@ describe('Notifications Service', function () {
|
|||
});
|
||||
});
|
||||
|
||||
describe('browse', function () {
|
||||
it('can browse non-major version upgrade notifications', function () {
|
||||
const settingsCache = {
|
||||
get: sinon.fake.returns([{
|
||||
dismissible: true,
|
||||
id: '130f7c24-113a-4768-a698-12a8b34223f1',
|
||||
type: 'info',
|
||||
message: `<strong>Ghost 5.1.3 is now available</strong> - You are using an old version of Ghost, which means you don't have access to the latest features. <a href=\'https://ghost.org/changelog/4/\' target=\'_blank\' rel=\'noopener\'>Read more!</a>`,
|
||||
createdAt: '2021-03-16T12:55:20.000Z',
|
||||
addedAt: '2021-03-17T01:41:20.906Z'
|
||||
}])
|
||||
};
|
||||
|
||||
const notificationSvc = new Notifications({
|
||||
settingsCache,
|
||||
ghostVersion: {
|
||||
full: '4.1.0'
|
||||
}
|
||||
});
|
||||
|
||||
const notifications = notificationSvc.browse({user: owner});
|
||||
|
||||
should.exist(notifications);
|
||||
notifications.length.should.equal(1);
|
||||
});
|
||||
|
||||
it('can browse major version upgrade notifications', function () {
|
||||
const settingsCache = {
|
||||
get: sinon.fake.returns([{
|
||||
dismissible: true,
|
||||
location: 'bottom',
|
||||
status: 'alert',
|
||||
id: '130f7c24-113a-4768-a698-12a8b34223f6',
|
||||
custom: true,
|
||||
createdAt: '2021-03-16T12:55:20.000Z',
|
||||
type: 'info',
|
||||
top: true,
|
||||
message: `<strong>Ghost 5.0 is now available</strong> - You are using an old version of Ghost, which means you don't have access to the latest features. <a href=\'https://ghost.org/changelog/4/\' target=\'_blank\' rel=\'noopener\'>Read more!</a>`,
|
||||
seen: true,
|
||||
addedAt: '2021-03-17T01:41:20.906Z',
|
||||
seenBy: ['1']
|
||||
}])
|
||||
};
|
||||
|
||||
const notificationSvc = new Notifications({
|
||||
settingsCache,
|
||||
ghostVersion: {
|
||||
full: '4.0.0'
|
||||
}
|
||||
});
|
||||
|
||||
const notifications = notificationSvc.browse({user: owner});
|
||||
|
||||
should.exist(notifications);
|
||||
notifications.length.should.equal(1);
|
||||
});
|
||||
|
||||
it('cannot see 2.0 version upgrade notifications in Ghost 3.0', function () {
|
||||
const settingsCache = {
|
||||
get: sinon.fake.returns([{
|
||||
dismissible: true,
|
||||
location: 'bottom',
|
||||
status: 'alert',
|
||||
id: '130f7c24-113a-4768-a698-12a8b34223f7',
|
||||
custom: true,
|
||||
createdAt: '2020-03-16T12:55:20.000Z',
|
||||
type: 'info',
|
||||
top: true,
|
||||
message: `<strong>Ghost 2.0 is now available</strong> - You are using an old version of Ghost, which means you don't have access to the latest features.`,
|
||||
seen: true,
|
||||
addedAt: '2020-03-17T01:41:20.906Z',
|
||||
seenBy: ['1']
|
||||
}])
|
||||
};
|
||||
|
||||
const notificationSvc = new Notifications({
|
||||
settingsCache,
|
||||
ghostVersion: {
|
||||
full: '3.0.0'
|
||||
}
|
||||
});
|
||||
|
||||
const notifications = notificationSvc.browse({user: owner});
|
||||
|
||||
should.exist(notifications);
|
||||
notifications.length.should.equal(0);
|
||||
});
|
||||
|
||||
it('cannot see 4.0 version upgrade notifications in Ghost 4.0', function () {
|
||||
const settingsCache = {
|
||||
get: sinon.fake.returns([{
|
||||
dismissible: true,
|
||||
location: 'bottom',
|
||||
status: 'alert',
|
||||
id: '130f7c24-113a-4768-a698-12a8b34223f8',
|
||||
custom: true,
|
||||
createdAt: '2021-03-16T12:55:20.000Z',
|
||||
type: 'info',
|
||||
top: true,
|
||||
message: `<strong>Ghost 4.0 is now available</strong> - You are using an old version of Ghost, which means you don't have access to the latest features.`,
|
||||
seen: true,
|
||||
addedAt: '2021-03-17T01:41:20.906Z',
|
||||
seenBy: ['1']
|
||||
}])
|
||||
};
|
||||
|
||||
const notificationSvc = new Notifications({
|
||||
settingsCache,
|
||||
ghostVersion: {
|
||||
full: '4.0.0'
|
||||
}
|
||||
});
|
||||
|
||||
const notifications = notificationSvc.browse({user: owner});
|
||||
|
||||
should.exist(notifications);
|
||||
notifications.length.should.equal(0);
|
||||
});
|
||||
|
||||
it('cannot see 5.0 version upgrade notifications in Ghost 5.0', function () {
|
||||
const settingsCache = {
|
||||
get: sinon.fake.returns([{
|
||||
dismissible: true,
|
||||
location: 'bottom',
|
||||
status: 'alert',
|
||||
id: '130f7c24-113a-4768-a698-12a8b34223f9',
|
||||
custom: true,
|
||||
createdAt: '2022-03-16T12:55:20.000Z',
|
||||
type: 'info',
|
||||
top: true,
|
||||
message: `<strong>Ghost 5.0 is now available</strong> - You are using an old version of Ghost, which means you don't have access to the latest features.`,
|
||||
seen: true,
|
||||
addedAt: '2022-03-17T01:41:20.906Z',
|
||||
seenBy: ['1']
|
||||
}])
|
||||
};
|
||||
|
||||
const notificationSvc = new Notifications({
|
||||
settingsCache,
|
||||
ghostVersion: {
|
||||
full: '5.0.0'
|
||||
}
|
||||
});
|
||||
|
||||
const notifications = notificationSvc.browse({user: owner});
|
||||
|
||||
should.exist(notifications);
|
||||
notifications.length.should.equal(0);
|
||||
});
|
||||
});
|
||||
|
||||
describe('Stored notifications data corruption recovery', function () {
|
||||
it('should correct broken notifications data on browse', function () {
|
||||
const settingsCache = {
|
||||
|
|
|
|||
Loading…
Reference in a new issue