Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-03-25 02:31:59 -05:00
Code Issues Activity

Added attribution counts to Pages API (#15289)

Browse source 
fixes https://github.com/TryGhost/Team/issues/1835

This was missed in the initial pass when adding to the Posts API
This commit is contained in:
Simon Backx 2022-08-23 16:26:34 +02:00 • committed by GitHub
parent 0695f74a65
commit d91d6c1311
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ghost/core/core/server/api/endpoints/pages.js
View file

@ -2,7 +2,7 @@ const models = require('../../models');
const tpl = require('@tryghost/tpl'); const tpl = require('@tryghost/tpl');
const errors = require('@tryghost/errors'); const errors = require('@tryghost/errors');
const getPostServiceInstance = require('../../services/posts/posts-service'); const getPostServiceInstance = require('../../services/posts/posts-service');
const ALLOWED_INCLUDES = ['tags', 'authors', 'authors.roles', 'tiers']; const ALLOWED_INCLUDES = ['tags', 'authors', 'authors.roles', 'tiers', 'count.signups', 'count.conversions'];
const UNSAFE_ATTRS = ['status', 'authors', 'visibility']; const UNSAFE_ATTRS = ['status', 'authors', 'visibility'];
const messages = { const messages = {

2
ghost/core/core/server/api/endpoints/utils/serializers/input/pages.js
View file

@ -23,7 +23,7 @@ function defaultRelations(frame) {
return false; return false;
} }
frame.options.withRelated = ['tags', 'authors', 'authors.roles', 'tiers']; frame.options.withRelated = ['tags', 'authors', 'authors.roles', 'tiers', 'count.signups', 'count.conversions'];
} }
function setDefaultOrder(frame) { function setDefaultOrder(frame) {

2
ghost/core/test/e2e-api/admin/pages.test.js
View file

@ -6,6 +6,7 @@ const testUtils = require('../../utils');
const config = require('../../../core/shared/config'); const config = require('../../../core/shared/config');
const models = require('../../../core/server/models'); const models = require('../../../core/server/models');
const localUtils = require('./utils'); const localUtils = require('./utils');
const mockManager = require('../../utils/e2e-framework-mock-manager');
describe('Pages API', function () { describe('Pages API', function () {
let request; let request;
@ -14,6 +15,7 @@ describe('Pages API', function () {
await localUtils.startGhost(); await localUtils.startGhost();
request = supertest.agent(config.get('url')); request = supertest.agent(config.get('url'));
await localUtils.doAuth(request, 'users:extra', 'posts'); await localUtils.doAuth(request, 'users:extra', 'posts');
mockManager.mockLabsDisabled('memberAttribution');
}); });
it('Can retrieve all pages', async function () { it('Can retrieve all pages', async function () {