mirror of
https://github.com/TryGhost/Ghost.git
synced 2025-04-08 02:52:39 -05:00
Fixed warnings in Tinybird test output for timezone tests (#22730)
no issue - Our Tinybird test suite has sanity checks that compare the sum of pageviews in a test result with the total number of rows in the fixture data. This sanity check runs against all tests that start with `all_`. - The timezone tests added last week used the `all_` prefix, but we wouldn't expect all rows in the fixture to be represented, since some rows are filtered out by timestamp - This commit renames all the timezone tests so the sanity check won't be run against these tests
This commit is contained in:
parent
f4cd2690d9
commit
d6c9100c5e
17 changed files with 3 additions and 2 deletions
ghost/web-analytics
scripts
tests
timezone_date_range_one_day_kpis.testtimezone_date_range_one_day_kpis.test.resulttimezone_kpis.testtimezone_kpis.test.resulttimezone_top_browsers.testtimezone_top_browsers.test.resulttimezone_top_devices.testtimezone_top_devices.test.resulttimezone_top_locations.testtimezone_top_locations.test.resulttimezone_top_os.testtimezone_top_os.test.resulttimezone_top_pages.testtimezone_top_pages.test.resulttimezone_top_sources.testtimezone_top_sources.test.result
|
@ -15,8 +15,9 @@ check_sum() {
|
|||
local file=$1
|
||||
local expected_count=$2
|
||||
|
||||
# Only perform the check if the file starts with "all_"
|
||||
if [[ ! $(basename "$file") =~ ^all_ ]]; then
|
||||
# Skip check if file starts with "all_" AND contains "timezone" in the name
|
||||
# TODO: we should handle this for all tests and in a better way
|
||||
if [[ ! $(basename "$file") =~ ^all_ ]] || [[ $(basename "$file") =~ timezone ]]; then
|
||||
return 0
|
||||
fi
|
||||
|
||||
|
|
Loading…
Add table
Reference in a new issue