Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-03 23:00:14 -05:00
Code Issues Activity

Checked structure of data in routes.yaml

Browse source 
fixes #11774

- providing data as a list ends up hitting code paths that can't handle
  arrays
- this ends up causing an InternalServerError
- this commit checks the input type is an object
- spotted in Sentry
This commit is contained in:
Daniel Lockyer 2020-04-27 17:06:29 +01:00
parent 18bd10308b
commit d6272eff42
1 changed files with 27 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
core/frontend/services/settings/validate.js
View file

@ -183,6 +183,15 @@ _private.validateData = function validateData(object) {
};
_private.validateRoutes = function validateRoutes(routes) {
if (routes.constructor !== Object) {
throw new common.errors.ValidationError({
message: common.i18n.t('errors.services.settings.yaml.validate', {
at: routes,
reason: '`routes` must be a YAML map.'
})
});
}
_.each(routes, (routingTypeObject, routingTypeObjectKey) => {
// CASE: we hard-require trailing slashes for the index route
if (!routingTypeObjectKey.match(/\/$/)) {
@ -223,6 +232,15 @@ _private.validateRoutes = function validateRoutes(routes) {
};
_private.validateCollections = function validateCollections(collections) {
if (collections.constructor !== Object) {
throw new common.errors.ValidationError({
message: common.i18n.t('errors.services.settings.yaml.validate', {
at: collections,
reason: '`collections` must be a YAML map.'
})
});
}
_.each(collections, (routingTypeObject, routingTypeObjectKey) => {
// CASE: we hard-require trailing slashes for the collection index route
if (!routingTypeObjectKey.match(/\/$/)) {
@ -310,6 +328,15 @@ _private.validateCollections = function validateCollections(collections) {
};
_private.validateTaxonomies = function validateTaxonomies(taxonomies) {
if (taxonomies.constructor !== Object) {
throw new common.errors.ValidationError({
message: common.i18n.t('errors.services.settings.yaml.validate', {
at: taxonomies,
reason: '`taxonomies` must be a YAML map.'
})
});
}
const validRoutingTypeObjectKeys = Object.keys(RESOURCE_CONFIG.TAXONOMIES);
_.each(taxonomies, (routingTypeObject, routingTypeObjectKey) => {
if (!routingTypeObject) {