From d5aa77bb7f489334e16f3531ad6ff7d6d2243208 Mon Sep 17 00:00:00 2001
From: Sag <guptazy@gmail.com>
Date: Tue, 15 Oct 2024 12:19:56 +0200
Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20Fixed=20missing=20'duplicate=20a?=
 =?UTF-8?q?=20post'=20feature=20for=20editors=20(#21304)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

ref https://linear.app/tryghost/issue/ENG-1647

- as per [staff user definitions](https://ghost.org/docs/staff), an
editor should be able to duplicate a post
- this feature was missing from the right-click menu on post/page lists
for editors
---
 .../components/posts-list/context-menu.hbs    | 12 ++-
 ghost/admin/tests/acceptance/content-test.js  | 74 +++++++++++++++++++
 2 files changed, 82 insertions(+), 4 deletions(-)

diff --git a/ghost/admin/app/components/posts-list/context-menu.hbs b/ghost/admin/app/components/posts-list/context-menu.hbs
index cb60862df8..aaf381b853 100644
--- a/ghost/admin/app/components/posts-list/context-menu.hbs
+++ b/ghost/admin/app/components/posts-list/context-menu.hbs
@@ -30,7 +30,7 @@
         {{/if}}
     {{/if}}
     {{#if this.canFeatureSelection}}
-        {{#if this.shouldFeatureSelection }}
+        {{#if this.shouldFeatureSelection}}
             <li>
                 <button class="mr2" type="button" {{on "click" this.featurePosts}} data-test-button="feature">
                     <span>{{svg-jar "star" class="mb1 star"}}Feature</span>
@@ -44,11 +44,13 @@
             </li>
         {{/if}}
     {{/if}}
+
     <li>
         <button class="mr2" type="button" {{on "click" this.addTagToPosts}} data-test-button="add-tag">
             <span>{{svg-jar "tag"}}Add a tag</span>
         </button>
     </li>
+
     {{#if this.membersUtils.isMembersEnabled}}
         <li>
             <button class="mr2" type="button" {{on "click" this.editPostsAccess}} data-test-button="change-access">
@@ -56,14 +58,16 @@
             </button>
         </li>
     {{/if}}
-    {{#if this.session.user.isAdmin}}
-        {{#if this.canCopySelection}}
+
+    {{#if this.canCopySelection}}
         <li>
             <button class="mr2" type="button" {{on "click" this.copyPosts}} data-test-button="duplicate">
                 <span>{{svg-jar "duplicate"}}Duplicate</span>
             </button>
         </li>
-        {{/if}}
+    {{/if}}
+
+    {{#if this.session.user.isAdmin}}
         <li>
             <button class="mr2" type="button" {{on "click" this.deletePosts}} data-test-button="delete">
                 <span class="red">{{svg-jar "trash"}}Delete</span>
diff --git a/ghost/admin/tests/acceptance/content-test.js b/ghost/admin/tests/acceptance/content-test.js
index e4eb0e6e6a..67d5b76f78 100644
--- a/ghost/admin/tests/acceptance/content-test.js
+++ b/ghost/admin/tests/acceptance/content-test.js
@@ -72,6 +72,27 @@ describe('Acceptance: Posts / Pages', function () {
                 expect(findAll('[data-test-post-id]')).to.have.length(1);
                 expect(find('[data-test-no-posts-box]')).to.not.exist;
             });
+
+            describe('context menu', function () {
+                let publishedPost;
+
+                beforeEach(async function () {
+                    publishedPost = this.server.create('post', {status: 'published'});
+                });
+
+                it('does not render the context menu', async function () {
+                    await visit('/posts');
+
+                    // get the post
+                    const post = find(`[data-test-post-id="${publishedPost.id}"]`);
+                    expect(post, 'post').to.exist;
+
+                    await triggerEvent(post, 'contextmenu');
+
+                    let contextMenu = find('.gh-posts-context-menu');
+                    expect(contextMenu, 'context menu').to.not.be.visible;
+                });
+            });
         });
 
         describe('as author', function () {
@@ -103,6 +124,59 @@ describe('Acceptance: Posts / Pages', function () {
                 expect(findAll('[data-test-post-id]').length, 'post count').to.equal(1);
                 expect(find(`[data-test-post-id="${authorPost.id}"]`), 'author post').to.exist;
             });
+
+            describe('context menu', function () {
+                it('does not render the context menu', async function () {
+                    await visit('/posts');
+
+                    // get the post
+                    const post = find(`[data-test-post-id="${authorPost.id}"]`);
+                    expect(post, 'post').to.exist;
+
+                    await triggerEvent(post, 'contextmenu');
+
+                    let contextMenu = find('.gh-posts-context-menu');
+                    expect(contextMenu, 'context menu').to.not.be.visible;
+                });
+            });
+        });
+
+        describe('as editor', function () {
+            let editor, editorPost;
+
+            beforeEach(async function () {
+                let editorRole = this.server.create('role', {name: 'Editor'});
+                editor = this.server.create('user', {roles: [editorRole]});
+                editorPost = this.server.create('post', {authors: [editor], status: 'published', title: 'Editor Post'});
+
+                await authenticateSession();
+            });
+
+            describe('context menu', function () {
+                it('renders the correct options', async function () {
+                    await visit('/posts');
+
+                    const post = find(`[data-test-post-id="${editorPost.id}"]`);
+                    expect(post, 'post').to.exist;
+
+                    await triggerEvent(post, 'contextmenu');
+
+                    // Test that the context menu is rendered
+                    const contextMenu = find('.gh-posts-context-menu');
+                    expect(contextMenu, 'context menu').to.exist;
+
+                    // Test that the context menu has the correct buttons
+                    const buttons = contextMenu.querySelectorAll('button');
+                    expect(buttons.length, 'context menu buttons').to.equal(5);
+                    expect(buttons[0].innerText.trim(), 'context menu button 1').to.contain('Copy link to post');
+                    expect(buttons[1].innerText.trim(), 'context menu button 2').to.contain('Unpublish');
+                    expect(buttons[2].innerText.trim(), 'context menu button 3').to.contain('Feature');
+                    expect(buttons[3].innerText.trim(), 'context menu button 4').to.contain('Add a tag');
+                    expect(buttons[4].innerText.trim(), 'context menu button 5').to.contain('Duplicate');
+                });
+
+                // Note: we cover the functionality of the context menu buttons in the 'as admin' section
+            });
         });
 
         describe('as admin', function () {