Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-17 23:44:39 -05:00
Code Issues Activity

Added tests for newsletter limits

Browse source 
refs https://github.com/TryGhost/Team/issues/1477
This commit is contained in:
Simon Backx 2022-06-02 11:21:29 +02:00
parent 557e268445
commit d5887c6ac0
1 changed files with 173 additions and 99 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

138
ghost/admin/tests/acceptance/settings/newsletters-test.js
View file

@ -5,38 +5,6 @@ import {setupApplicationTest} from 'ember-mocha';
import {setupMirage} from 'ember-cli-mirage/test-support';
import {visit} from '../../helpers/visit';
describe('Acceptance: Settings - Newsletters', function () {
const hooks = setupApplicationTest();
setupMirage(hooks);
beforeEach(async function () {
this.server.loadFixtures('configs', 'newsletters');
const role = this.server.create('role', {name: 'Owner'});
this.server.create('user', {roles: [role]});
return await authenticateSession();
});
it('redirects old path', async function () {
await visit('/settings/members-email');
expect(currentURL()).to.equal('/settings/newsletters');
});
it('can manage open rate tracking', async function () {
this.server.db.settings.update({key: 'email_track_opens'}, {value: 'true'});
await visit('/settings/newsletters');
expect(find('[data-test-checkbox="email-track-opens"]')).to.be.checked;
await click('[data-test-label="email-track-opens"]');
expect(find('[data-test-checkbox="email-track-opens"]')).to.not.be.checked;
await click('[data-test-button="save-members-settings"]');
expect(this.server.db.settings.findBy({key: 'email_track_opens'}).value).to.equal(false);
});
async function checkValidationError(errors) {
// Create the newsletter
await click('[data-test-button="save-newsletter"]');
@ -136,6 +104,38 @@ describe('Acceptance: Settings - Newsletters', function () {
await fillIn('input#newsletter-title', name);
}
describe('Acceptance: Settings - Newsletters', function () {
const hooks = setupApplicationTest();
setupMirage(hooks);
beforeEach(async function () {
this.server.loadFixtures('configs', 'newsletters');
const role = this.server.create('role', {name: 'Owner'});
this.server.create('user', {roles: [role]});
return await authenticateSession();
});
it('redirects old path', async function () {
await visit('/settings/members-email');
expect(currentURL()).to.equal('/settings/newsletters');
});
it('can manage open rate tracking', async function () {
this.server.db.settings.update({key: 'email_track_opens'}, {value: 'true'});
await visit('/settings/newsletters');
expect(find('[data-test-checkbox="email-track-opens"]')).to.be.checked;
await click('[data-test-label="email-track-opens"]');
expect(find('[data-test-checkbox="email-track-opens"]')).to.not.be.checked;
await click('[data-test-button="save-members-settings"]');
expect(this.server.db.settings.findBy({key: 'email_track_opens'}).value).to.equal(false);
});
describe('Creating newsletters', function () {
it('can create new newsletter', async function () {
await visit('/settings/newsletters');
@ -169,6 +169,34 @@ describe('Acceptance: Settings - Newsletters', function () {
// Everything should be valid
await checkSave({});
});
it('checks limits when creating a newsletter', async function () {
const config = this.server.db.configs.find(1);
config.hostSettings = {
limits: {
newsletters: {
max: 1,
error: 'Your plan supports up to {{max}} newsletters. Please upgrade to add more.'
}
}
};
this.server.db.configs.update(1, config);
await visit('/settings/newsletters');
await click('[data-test-button="add-newsletter"]');
// Check if modal doesn't open
expect(find('[data-test-modal="create-newsletter"]'), 'Create newsletter modal').not.to.exist;
// Check limits modal is shown
expect(find('[data-test-modal="limits/multiple-newsletters"]'), 'Limits modal').to.exist;
// Check can close modal
await click('[data-test-button="cancel-upgrade"]');
// Check modal is closed
expect(find('[data-test-modal="limits/multiple-newsletters"]'), 'Limits modal').not.to.exist;
});
});
describe('Editing newsletters', function () {
@ -493,5 +521,51 @@ describe('Acceptance: Settings - Newsletters', function () {
// Check total newsletters shown
expect(findAll('[data-test-newsletter]').length, 'Total newsletters shown').to.equal(3);
});
it('checks limits when reactivating a newsletter', async function () {
const config = this.server.db.configs.find(1);
config.hostSettings = {
limits: {
newsletters: {
max: 1,
error: 'Your plan supports up to {{max}} newsletters. Please upgrade to add more.'
}
}
};
this.server.db.configs.update(1, config);
// Create an archived newsletter, beacuse the toggle is invisible otherwise
this.server.create('newsletter', {status: 'archived', name: 'test newsletter 2', slug: 'test-newsletter2'});
await visit('/settings/newsletters');
// Check total newsletters shown
expect(findAll('[data-test-newsletter]').length, 'Total newsletters shown').to.equal(1);
// Go to archived newsletters
await click('[data-test-dropdown="newsletter-status-filter"] .ember-power-select-trigger');
await click('.ember-power-select-option[aria-selected="false"]');
// Check title okay
expect(find('.gh-newsletters .gh-expandable-title').textContent.trim(), 'Title').to.equal('Archived newsletters');
// Check total newsletters shown
expect(findAll('[data-test-newsletter]').length, 'Total archived newsletters shown').to.equal(1);
// Reactivate the newsletter
await click('[data-test-newsletter-menu-trigger]');
await click('[data-test-button="reactivate-newsletter"]');
// Check if confimation modal doesn't open
expect(find('[data-test-modal="confirm-newsletter-reactivate"]'), 'Reactivate newsletter modal').not.to.exist;
// Check limits modal is shown
expect(find('[data-test-modal="limits/multiple-newsletters"]'), 'Limits modal').to.exist;
// Check can close modal
await click('[data-test-button="cancel-upgrade"]');
// Check modal is closed
expect(find('[data-test-modal="limits/multiple-newsletters"]'), 'Limits modal').not.to.exist;
});
});
});