From d4fe7217d6026772ec3c2213584498a0dbd6fb63 Mon Sep 17 00:00:00 2001
From: Fabien 'egg' O'Carroll <fabien@allou.is>
Date: Tue, 11 Apr 2023 13:25:49 +0700
Subject: [PATCH] Removed feature action from context menu for email-only posts
 (#16606)

These posts make no sense to be featured, so we are removing the option
from the context menu when there is only a single email-only post under
selection.

We still allow featuring these posts in the PSM and when they are
part of a larger selection, but fixing all places for this is out of
scope atm.
---
 .../components/posts-list/context-menu.hbs    | 24 ++++++++++---------
 .../app/components/posts-list/context-menu.js |  7 ++++++
 2 files changed, 20 insertions(+), 11 deletions(-)

diff --git a/ghost/admin/app/components/posts-list/context-menu.hbs b/ghost/admin/app/components/posts-list/context-menu.hbs
index 2d3ba2b027..05b2a308b8 100644
--- a/ghost/admin/app/components/posts-list/context-menu.hbs
+++ b/ghost/admin/app/components/posts-list/context-menu.hbs
@@ -11,18 +11,20 @@
             <span>Unpublish</span>
         </button>
     </li>
-    {{#if this.shouldFeatureSelection }}
-        <li>
-            <button class="mr2" type="button" {{on "click" this.featurePosts}}>
-                <span>Feature</span>
-            </button>
-        </li>
-    {{else}}
+    {{#if this.canFeatureSelection}}
+        {{#if this.shouldFeatureSelection }}
             <li>
-            <button class="mr2" type="button" {{on "click" this.unfeaturePosts}}>
-                <span>Unfeature</span>
-            </button>
-        </li>
+                <button class="mr2" type="button" {{on "click" this.featurePosts}}>
+                    <span>Feature</span>
+                </button>
+            </li>
+        {{else}}
+                <li>
+                <button class="mr2" type="button" {{on "click" this.unfeaturePosts}}>
+                    <span>Unfeature</span>
+                </button>
+            </li>
+        {{/if}}
     {{/if}}
     <li>
         <button class="mr2" type="button" disabled {{on "click" @menu.close}}>
diff --git a/ghost/admin/app/components/posts-list/context-menu.js b/ghost/admin/app/components/posts-list/context-menu.js
index 260357a671..80136b523c 100644
--- a/ghost/admin/app/components/posts-list/context-menu.js
+++ b/ghost/admin/app/components/posts-list/context-menu.js
@@ -42,6 +42,13 @@ export default class PostsContextMenu extends Component {
         return !firstPost.featured;
     }
 
+    get canFeatureSelection() {
+        if (!this.selectionList.isSingle) {
+            return true;
+        }
+        return this.selectionList.availableModels[0].get('status') !== 'sent';
+    }
+
     @action
     async featurePosts() {
         const updatedModels = this.selectionList.availableModels;