From d2bb50a4368a5cbd6b20a205f04a95002a5432e8 Mon Sep 17 00:00:00 2001 From: Fabien O'Carroll Date: Mon, 28 Sep 2020 13:06:58 +0100 Subject: [PATCH] Refactored async function to throw errors no-issue There's no need to return rejected promises in an async function as thrown errors will behave the same, this just makes it a little cleaner. --- ghost/members-api/index.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ghost/members-api/index.js b/ghost/members-api/index.js index b8f05a3ac2..6d3bc5f4f5 100644 --- a/ghost/members-api/index.js +++ b/ghost/members-api/index.js @@ -164,9 +164,9 @@ module.exports = function MembersApi({ async function setMemberGeolocationFromIp(email, ip) { if (!email || !ip) { - return Promise.reject(new common.errors.IncorrectUsageError({ + throw new common.errors.IncorrectUsageError({ message: 'setMemberGeolocationFromIp() expects email and ip arguments to be present' - })); + }); } const member = await users.get(email, { @@ -174,9 +174,9 @@ module.exports = function MembersApi({ }); if (!member) { - return Promise.reject(new common.errors.NotFoundError({ + throw new common.errors.NotFoundError({ message: `Member with email address ${email} does not exist` - })); + }); } // max request time is 500ms so shouldn't slow requests down too much