Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-10 23:36:14 -05:00
Code Issues Activity

🐛 Fixed issue where single letter product slugs cause 500 error (#16821)

Browse source 
refs https://github.com/TryGhost/Team/issues/3224

When a product has a slug that is a single letter, checking if a user
had access to view a post associated with that product would cause a 500
error. The underlying cause of this issue is
https://github.com/TryGhost/NQL/issues/20 This fix circumvents this
issue by providing a value that the nql lexer will not error out on
This commit is contained in:
Michael Barrett 2023-05-18 09:38:30 +01:00 • committed by GitHub
parent 9bdbe92183
commit cde30eb469
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ghost/core/core/server/services/members/content-gating.js
View file

@ -46,7 +46,7 @@ function checkPostAccess(post, member) {
return BLOCK_ACCESS;
}
visibility = post.tiers.map((product) => {
return `product:${product.slug}`;
return `product:'${product.slug}'`;
}).join(',');
}

9
ghost/core/test/unit/server/services/members/content-gating.test.js
View file

@ -44,6 +44,15 @@ describe('Members Service - Content gating', function () {
should(access).be.true();
});
it('should not error out if the slug associated with a tier is only 1 character in length', async function () {
post = {visibility: 'tiers', tiers: [{slug: 'x'}]};
member = {id: 'test', status: 'paid', products: [{
slug: 'x'
}]};
(() => checkPostAccess(post, member)).should.not.throw();
});
it('should block access to members only post without member', async function () {
post = {visibility: 'members'};
member = null;