Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-03-11 02:12:21 -05:00
Code Issues Activity

Fixed login / logout with 2fa code

Browse source 
refs ENG-1640

We had built all the right pieces, but the session endpoints weren't
verifying the service
This commit is contained in:
Sam Lord 2024-10-10 14:22:24 +01:00 • committed by Kevin Ansfield
parent 3bf0b7d8ed
commit cb8d18423a
2 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
ghost/core/core/server/services/auth/session/middleware.js
View file

@ -42,7 +42,8 @@ function SessionMiddleware({sessionService}) {
async function authenticate(req, res, next) {
try {
const user = await sessionService.getUserForSession(req, res);
if (user) {
const isVerified = await sessionService.isVerifiedSession(req, res);
if (user && isVerified) {
// Do not nullify `req.user` as it might have been already set
// in a previous middleware (authorize middleware).
req.user = user;
@ -68,6 +69,7 @@ function SessionMiddleware({sessionService}) {
const verified = await sessionService.verifyAuthCodeForUser(req, res);
if (verified) {
await sessionService.verifySession(req, res);
res.sendStatus(200);
} else {
res.sendStatus(401);

3
ghost/core/test/unit/server/services/auth/session/middleware.test.js
View file

@ -204,7 +204,8 @@ describe('Session Service', function () {
const middleware = SessionMiddlware({
sessionService: {
verifyAuthCodeForUser: verifyAuthCodeForUserStub
verifyAuthCodeForUser: verifyAuthCodeForUserStub,
verifySession: sinon.stub().resolves(true)
}
});