Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-03 23:00:14 -05:00
Code Issues Activity

Checked null & undefined in settings migration (#10609)

Browse source 
no-issue

This is to make sure we catch all falsy cases of values.
This commit is contained in:
Fabien O'Carroll 2019-03-13 23:35:23 +01:00 • committed by GitHub
parent 02c56e90e5
commit ca16b197a2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
core/server/data/migrations/versions/2.17/1-normalize-settings.js
View file

@ -41,7 +41,7 @@ module.exports.up = (options) => {
} }
// @NOTE: null or undefined were obviously intended to be false // @NOTE: null or undefined were obviously intended to be false
if (entry.value === 'null' || entry.value === 'undefined') { if (entry.value === null || entry.value === undefined || entry.value === 'null' || entry.value === 'undefined') {
const value = 'false'; const value = 'false';
common.logging.info(`Setting ${entry.key} to ${value} because it was ${entry.value}`); common.logging.info(`Setting ${entry.key} to ${value} because it was ${entry.value}`);