From c9e0c252f07c426af429926eceafc4bd740466f7 Mon Sep 17 00:00:00 2001
From: Kevin Ansfield <kevin@lookingsideways.co.uk>
Date: Thu, 30 Mar 2017 13:27:07 +0100
Subject: [PATCH] =?UTF-8?q?=E2=9C=A8=20`grunt=20dev`=20admin=20livereload?=
 =?UTF-8?q?=20(#8176)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

refs https://github.com/TryGhost/Ghost/issues/8161, requires https://github.com/TryGhost/Ghost-Admin/pull/590
- adds a development-only route to the admin app that redirects to ember-cli's livereload script
- updates Gruntfile `watch` task to pass the `live-reload-base-url` param with subdirectory support
- updates Gruntfile `bgShell:client` task to filter potentially confusing output from `ember serve`
  - removes `Livereload server on http://localhost:49153`
  - removes `Serving on http://localhost:4200/`

With this and the required Ghost-Admin PR, when using `grunt dev` the admin screen will refresh any time a file is changed. It will also allow client tests to be run simultaneously by visiting http://localhost:4200/tests
---
 Gruntfile.js             | 20 ++++++++++++++++++--
 core/server/admin/app.js |  7 +++++++
 2 files changed, 25 insertions(+), 2 deletions(-)

diff --git a/Gruntfile.js b/Gruntfile.js
index c59454f567..171c529b71 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -9,6 +9,7 @@
 // jshint unused: false
 var overrides      = require('./core/server/overrides'),
     config         = require('./core/server/config'),
+    utils          = require('./core/server/utils'),
     _              = require('lodash'),
     chalk          = require('chalk'),
     fs             = require('fs-extra'),
@@ -219,7 +220,20 @@ var overrides      = require('./core/server/overrides'),
                 client: {
                     cmd: 'grunt subgrunt:watch',
                     bg: true,
-                    stdout: true,
+                    stdout: function (chunk) {
+                        // hide certain output to prevent confusion
+                        var filter = [
+                            /> ghost-admin/,
+                            /^Livereload/,
+                            /^Serving on/
+                        ].some(function (regexp) {
+                            return regexp.test(chunk);
+                        });
+
+                        if (!filter) {
+                            grunt.log.write(chunk);
+                        }
+                    },
                     stderr: true
                 }
             },
@@ -339,7 +353,9 @@ var overrides      = require('./core/server/overrides'),
                 },
 
                 watch: {
-                    'core/client': 'shell:ember:watch'
+                    projects: {
+                        'core/client': ['shell:ember:watch', '--live-reload-base-url="' + utils.url.getSubdir() + '/ghost/"']
+                    }
                 }
             }
         };
diff --git a/core/server/admin/app.js b/core/server/admin/app.js
index 76e0473a98..35075162b4 100644
--- a/core/server/admin/app.js
+++ b/core/server/admin/app.js
@@ -36,6 +36,13 @@ module.exports = function setupAdminApp() {
     // Service Worker for offline support
     adminApp.get(/^\/(sw.js|sw-registration.js)$/, require('./serviceworker'));
 
+    // Ember CLI's live-reload script
+    if (config.get('env') === 'development') {
+        adminApp.get('/ember-cli-live-reload.js', function (req, res) {
+            res.redirect('http://localhost:4200' + utils.url.getSubdir() + '/ghost/ember-cli-live-reload.js');
+        });
+    }
+
     // Render error page in case of maintenance
     adminApp.use(maintenance);