Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-20 22:42:53 -05:00
Code Issues Activity

Used attributedTo over actor when available (#20998)

Browse source 
refs https://linear.app/tryghost/issue/AP-388

The attributedTo property of objects refers to the author of the object,
wheras the actor of an activity refers to the author of the activity -
in the case of a `Create` activity - these are generally the same, but
in the case of an `Announce` they are different, the author refers to
the "announcer" and the attributedTo the author of the content! This is
a quick patch to use the true author when it's available, and in a
format we can handle.
This commit is contained in:
Fabien 'egg' O'Carroll 2024-09-13 12:54:25 +07:00 • committed by GitHub
parent a5b1f2e9fa
commit c98ff3856e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 25 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
apps/admin-x-activitypub/src/components/Inbox.tsx
View file

@ -53,6 +53,30 @@ const Inbox: React.FC<InboxProps> = ({}) => {
NiceModal.show(ArticleModal, {object, actor, comments, allComments: commentsMap});
};
function getContentAuthor(activity: Activity) {
const actor = activity.actor;
const attributedTo = activity.object.attributedTo;
if (!attributedTo) {
return actor;
}
if (typeof attributedTo === 'string') {
return actor;
}
if (Array.isArray(attributedTo)) {
const found = attributedTo.find(item => typeof item !== 'string');
if (found) {
return found;
} else {
return actor;
}
}
return attributedTo;
}
const handleLayoutChange = (newLayout: string) => {
setLayout(newLayout);
};
@ -70,7 +94,7 @@ const Inbox: React.FC<InboxProps> = ({}) => {
data-test-view-article
onClick={() => handleViewContent(
activity.object,
activity.actor,
getContentAuthor(activity),
getCommentsForObject(activity.object.id)
)}
>