Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-04-08 02:52:39 -05:00
Code Issues Activity

Fixed white page during one click subscribe flow (#18074)

Browse source 
no issue

In Chrome, opening a new tab immediately focusses it, even when trying
to blur or focus the main window.
This commit is contained in:
Simon Backx 2023-09-12 10:36:50 +02:00 • committed by GitHub
parent 1b1d871374
commit c863ed2188
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
apps/portal/src/components/pages/RecommendationsPage.js
View file

@ -66,16 +66,12 @@ const RecommendationIcon = ({title, favicon, featuredImage}) => {
return (<img className="gh-portal-recommendation-item-favicon" src={icon} alt={title} onError={hideIcon} />);
};
const prepareTab = () => {
return window.open('', '_blank');
};
const openTab = (tab, url) => {
const openTab = (url) => {
const tab = window.open(url, '_blank');
if (tab) {
tab.location.href = url;
tab.focus();
} else {
// Probably failed to create a tab
// Safari fix after async operation / failed to create a new tab
window.location.href = url;
}
};
@ -88,28 +84,22 @@ const RecommendationItem = (recommendation) => {
const visitHandler = useCallback(() => {
// Open url in a new tab
const tab = window.open(url, '_blank');
tab?.focus();
openTab(url);
}, [url]);
const oneClickSubscribeHandler = useCallback(async () => {
// We need to open a tab immediately, otherwise it is not possible to open a tab in case of errors later
// after the async operation is done (browser blocks it outside of user interaction)
const tab = prepareTab();
try {
await onAction('oneClickSubscribe', {
siteUrl: url,
throwErrors: true
});
setSubscribed(true);
tab.close();
} catch (_) {
// Open portal signup page
const signupUrl = new URL('#/portal/signup', url);
// Trigger a visit
openTab(tab, signupUrl);
openTab(signupUrl);
}
}, [setSubscribed, url]);