From c5224b4d318ab6f0ebe94fab704ffe6421719680 Mon Sep 17 00:00:00 2001 From: Hannah Wolfe Date: Mon, 22 Jan 2018 14:48:33 +0000 Subject: [PATCH] =?UTF-8?q?=F0=9F=9B=A0=20Change=20setup=20tooling=20to=20?= =?UTF-8?q?use=20`yarn=20setup`=20(#9413)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit no issue 1. renamed alias: - we have a special alias that does initial setup tasks that are only supposed to be run once - changing the alias to be `setup` rather than `init` otherwise it is too easy to confuse with `grunt init` 2. require globals to be installed manually - yarn is RUBBISH at managing globals - internally we use npm for this (actually we have a managed list of globals) and yarn for everything else - by moving this to documentation, rather than a command, we have flexibility to do this differently - also explicit globals are better than installing these without the user knowing IMO 3. setup includes knex-migrator - do this automatically instead of knex-migrator init being a separate command - every other time knex-migrator is needed, Ghost _should_ tell you what to do --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index b0ee2fbca2..afde60b5b7 100644 --- a/package.json +++ b/package.json @@ -21,7 +21,7 @@ "start": "node index", "dev": "DEBUG=ghost:* grunt dev", "test": "grunt validate --verbose", - "init": "yarn global add knex-migrator ember-cli grunt-cli && yarn install && grunt symlink && grunt init || true" + "setup": "yarn install && knex-migrator init && grunt symlink && grunt init || true" }, "engines": { "node": "^4.5.0 || ^6.9.0 || ^8.9.0",