From c4ad61ac0fbbcd997db4e1368feacd6fac11e04a Mon Sep 17 00:00:00 2001
From: Kevin Ansfield <kevin@lookingsideways.co.uk>
Date: Wed, 27 Apr 2022 10:49:55 +0100
Subject: [PATCH] Added disabled newsletter dropdown to scheduled state of
 publish menu (#2357)

no issue

If you scheduled a post to a specific newsletter it was no longer visible in the scheduled state of the publish menu making it difficult to know the behaviour when coming back to a scheduled post.

- duplicated the newsletter dropdown from the draft to the scheduled state components and disabled it the same as the other recipient options
- added temporary workaround for missing newsletter embed for the posts endpoint in the API
  - adds `newsletterId` attribute to the post model
  - uses `post.newsletterId` to find the matching newsletter model from the available newsletters list
---
 ghost/admin/.template-lintrc.js                |  2 +-
 .../components/gh-publishmenu-scheduled.hbs    | 18 ++++++++++++++++++
 .../app/components/gh-publishmenu-scheduled.js |  4 ++++
 ghost/admin/app/components/gh-publishmenu.hbs  |  1 +
 ghost/admin/app/models/post.js                 |  3 +++
 5 files changed, 27 insertions(+), 1 deletion(-)

diff --git a/ghost/admin/.template-lintrc.js b/ghost/admin/.template-lintrc.js
index 44cb37a9aa..59d6e9283a 100644
--- a/ghost/admin/.template-lintrc.js
+++ b/ghost/admin/.template-lintrc.js
@@ -3,7 +3,7 @@ module.exports = {
 
     rules: {
         'no-forbidden-elements': ['meta', 'html', 'script'],
-        'no-implicit-this': {allow: ['now', 'site-icon-style', 'accent-color-background']},
+        'no-implicit-this': {allow: ['noop', 'now', 'site-icon-style', 'accent-color-background']},
         'no-inline-styles': false
     }
 };
diff --git a/ghost/admin/app/components/gh-publishmenu-scheduled.hbs b/ghost/admin/app/components/gh-publishmenu-scheduled.hbs
index 1dde13f0e6..66583d6af9 100644
--- a/ghost/admin/app/components/gh-publishmenu-scheduled.hbs
+++ b/ghost/admin/app/components/gh-publishmenu-scheduled.hbs
@@ -38,6 +38,24 @@
                         <div class="gh-publishmenu-email-label pe-none">
                             <label class="gh-publishmenu-radio-label mb3 midgrey">Send by email to</label>
 
+                            {{#if (and (feature "multipleNewsletters") (gt @availableNewsletters.length 1))}}
+                                <div class="mb3">
+                                    <PowerSelect
+                                        @selected={{this.selectedNewsletter}}
+                                        @options={{@availableNewsletters}}
+                                        @onChange={{noop}}
+                                        @triggerComponent="gh-power-select/trigger"
+                                        @triggerClass="gh-publishmenu-newsletter-trigger"
+                                        @dropdownClass="gh-publishmenu-newsletter-dropdown"
+                                        @renderInPlace={{true}}
+                                        @disabled={{true}}
+                                        as |newsletter|
+                                    >
+                                        {{newsletter.name}}
+                                    </PowerSelect>
+                                </div>
+                            {{/if}}
+
                             <div class="form-group">
                                 <GhMembersRecipientSelect
                                     @filter={{@recipientsFilter}}
diff --git a/ghost/admin/app/components/gh-publishmenu-scheduled.js b/ghost/admin/app/components/gh-publishmenu-scheduled.js
index 63841ff410..dde47217e7 100644
--- a/ghost/admin/app/components/gh-publishmenu-scheduled.js
+++ b/ghost/admin/app/components/gh-publishmenu-scheduled.js
@@ -26,6 +26,10 @@ export default class GhPublishmenuScheduledComponent extends Component {
         return publishedAtUTC.toNow(true);
     }
 
+    get selectedNewsletter() {
+        return this.args.availableNewsletters.find(n => n.id === this.args.post.newsletterId);
+    }
+
     constructor() {
         super(...arguments);
         this.minDate = new Date();
diff --git a/ghost/admin/app/components/gh-publishmenu.hbs b/ghost/admin/app/components/gh-publishmenu.hbs
index 06f33d9a3f..d582c5e0f8 100644
--- a/ghost/admin/app/components/gh-publishmenu.hbs
+++ b/ghost/admin/app/components/gh-publishmenu.hbs
@@ -26,6 +26,7 @@
                 @setTypedDateError={{action (mut this.typedDateError)}}
                 @isSendingEmailLimited={{this.isSendingEmailLimited}}
                 @sendingEmailLimitError={{this.sendingEmailLimitError}}
+                @availableNewsletters={{this.availableNewsletters}}
                 data-test-publishmenu-scheduled="true" />
 
         {{else}}
diff --git a/ghost/admin/app/models/post.js b/ghost/admin/app/models/post.js
index 230777eed4..20a47217c4 100644
--- a/ghost/admin/app/models/post.js
+++ b/ghost/admin/app/models/post.js
@@ -111,6 +111,9 @@ export default Model.extend(Comparable, ValidationEngine, {
     featureImageAlt: attr('string'),
     featureImageCaption: attr('string'),
 
+    // TODO: delete when newsletter relationship/embed is fully defined
+    newsletterId: attr(),
+
     authors: hasMany('user', {embedded: 'always', async: false}),
     createdBy: belongsTo('user', {async: true}),
     email: belongsTo('email', {async: false}),