Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-24 23:48:13 -05:00
Code Issues Activity

Koenig - Prevent "Enter" being inserted into captions

Browse source 
refs https://github.com/TryGhost/Ghost/issues/9724
- mobiledoc-kit's `key.isPrintable()` returns true for <kbd>Enter</kbd> but in this instance we don't want to capture newlines as printable chars
- swapped insertion of `event.key` for `key.toString()` for better handling of named keys that output characters (eg. when `event.key` === `Enter` which prints `\n`)
This commit is contained in:
Kevin Ansfield 2018-08-11 18:26:30 +01:00
parent 6943e1d27a
commit c33a0c23bc
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
ghost/admin/lib/koenig-editor/addon/components/koenig-caption-input.js
View file

@ -90,10 +90,10 @@ export default Component.extend({
let key = new Key(event); let key = new Key(event);
let {editor} = this; let {editor} = this;
if (event.target.matches('[data-kg="editor"]') && editor && !editor._hasFocus() && key.isPrintableKey()) { if (event.target.matches('[data-kg="editor"]') && editor && !editor._hasFocus() && key.isPrintableKey() && !key.isEnter()) {
editor.focus(); editor.focus();
editor.run((postEditor) => { editor.run((postEditor) => {
postEditor.insertText(editor.post.tailPosition(), event.key); postEditor.insertText(editor.post.tailPosition(), key.toString());
}); });
event.preventDefault(); event.preventDefault();