From c201e4eb4f739794f0c67fcf44bc649347a245b9 Mon Sep 17 00:00:00 2001 From: Sag Date: Mon, 7 Aug 2023 16:48:25 +0200 Subject: [PATCH] Fixed preset amount in Stripe Checkout (#17615) refs https://github.com/TryGhost/Product/issues/3666 - Stripe has a set of minimum charges per currency. This adds a basic safeguard on the backend side, while the main validation should happen in Portal - Stripe docs: https://stripe.com/docs/currencies#minimum-and-maximum-charge-amounts --- ghost/payments/lib/PaymentsService.js | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/ghost/payments/lib/PaymentsService.js b/ghost/payments/lib/PaymentsService.js index e6a95c3bc6..f268fc5d65 100644 --- a/ghost/payments/lib/PaymentsService.js +++ b/ghost/payments/lib/PaymentsService.js @@ -283,8 +283,9 @@ class PaymentsService { const currency = this.settingsCache.get('donations_currency'); const suggestedAmount = this.settingsCache.get('donations_suggested_amount'); - // Stripe requires a minimum of 50 cents - const amount = suggestedAmount && suggestedAmount > 50 ? suggestedAmount : 0; + // Stripe requires a minimum charge amount + // @see https://stripe.com/docs/currencies#minimum-and-maximum-charge-amounts + const amount = suggestedAmount && suggestedAmount >= 100 ? suggestedAmount : 0; const price = await this.StripePriceModel .where({ @@ -338,13 +339,15 @@ class PaymentsService { async createPriceForDonations({currency, amount, nickname}) { const product = await this.getProductForDonations({name: nickname}); + const preset = amount ? amount : null; + // Create the price in Stripe const price = await this.stripeAPIService.createPrice({ currency, product: product.id, custom_unit_amount: { enabled: true, - preset: amount + preset }, nickname, type: 'one-time',