Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-20 22:42:53 -05:00
Code Issues Activity

Added migration to fix data discrepancy in free tier visibility (#19624)

Browse source 
refs INC-18

- release v5.69.0 introduced a data discrepancy in the free tier
visibility: the "free" tier visibility got out of sync with the
"portal_plans" setting due to a bug in the new Admin settings. The bug
was corrected in a patch release rolled out a few days later, v5.69.4
- however, the data discrepancy has not been corrected for all
customers; this data migration fixes the data discrepancy
This commit is contained in:
Sag 2024-02-01 16:53:40 +01:00 • committed by GitHub
parent 94edc0c856
commit c12e279e0c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 43 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

43
ghost/core/core/server/data/migrations/versions/5.79/2024-01-30-19-36-44-fix-discrepancy-in-free-tier-visibility.js Normal file
View file

@ -0,0 +1,43 @@
const {createTransactionalMigration} = require('../../utils');
const logging = require('@tryghost/logging');
module.exports = createTransactionalMigration(
async function up(knex) {
const portalPlansRaw = await knex('settings').select('value').where('key', 'portal_plans').first();
const freeTier = await knex('products').select('visibility').where('type', 'free').first();
if (!portalPlansRaw || !freeTier) {
logging.warn('Could not read `portal_plans` setting or `visibility` of the free tier - skipping migration');
return;
}
let portalPlans;
try {
portalPlans = JSON.parse(portalPlansRaw.value);
if (!portalPlans || !Array.isArray(portalPlans)) {
logging.warn('`portal_plans` setting is not valid - skipping migration');
return;
}
} catch (err) {
logging.warn('Could not parse `portal_plans` setting - skipping migration');
return;
}
if (portalPlans.includes('free') && freeTier.visibility === 'none') {
logging.info('`portal_plans` setting contains "free", but free tier is not visible - updating free tier visibility to public');
await knex('products').update('visibility', 'public').where('type', 'free');
return;
}
if (!portalPlans.includes('free') && freeTier.visibility === 'public') {
logging.info('`portal_plans` setting does not contain "free", but free tier is visible - updating free tier visibility to none');
await knex('products').update('visibility', 'none').where('type', 'free');
return;
}
},
async function down() {
// noop, as this is a data discrepancy fix
}
);