Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-04-01 02:41:39 -05:00
Code Issues Activity

Updated webhooks cleanup to handle all older webhooks (#186)

Browse source 
refs https://github.com/TryGhost/Ghost/issues/12074

Some sites may have had duplicate webhooks created due to a race
condition. This updates the members-api to cleanup _all_ webhooks before
starting, allowing it to create webhooks on a fresh slate, and removing
possible causes of 401 errors due to incorrect webhook secrets.
This commit is contained in:
Fabien 'egg' O'Carroll 2020-07-22 12:27:48 +02:00 • committed by GitHub
parent cdfa31af1a
commit bf38d836d4
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
ghost/members-api/lib/stripe/index.js
View file

@ -90,11 +90,11 @@ module.exports = class StripePaymentProcessor {
limit: 100
});
const webhookToCleanup = webhooks.data.find((webhook) => {
return webhook.url === config.webhookHandlerUrl.slice(0, -1);
const webhooksToCleanup = webhooks.data.filter((webhook) => {
return webhook.url === config.webhookHandlerUrl.slice(0, -1) || webhook.url === config.webhookHandlerUrl;
});
if (webhookToCleanup) {
for (const webhookToCleanup of webhooksToCleanup) {
await del(this._stripe, 'webhookEndpoints', webhookToCleanup.id);
}
} catch (err) {