Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-06 22:40:14 -05:00
Code Issues Activity

🐛 Fixed url decoding issue - URLs sent in emails containing a % can now be updated(#20518)

Browse source 
fixes https://linear.app/tryghost/issue/ENG-447/🐛-urls-sent-in-emails-containing-a-percent-can-not-be-updated

URLs were decoded before making a search query to the db. This is the reason the `%2F` character gets converted to  `/`. This decoding is not required.
This commit is contained in:
Princi Vershwal 2024-07-02 21:13:32 +05:30 committed by GitHub
parent b36c2356fc
commit bec647412f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 0 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
ghost/link-tracking/lib/LinkClickTrackingService.js
View file

@ -105,9 +105,6 @@ class LinkClickTrackingService {
* @throws {errors.BadRequestError}
*/
#parseLinkFilter(filter) {
// decode filter to manage any encoded uri components
filter = decodeURIComponent(filter);
try {
const filterJson = nql(filter).parse();
const postId = filterJson?.$and?.[0]?.post_id;