Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-24 23:48:13 -05:00
Code Issues Activity

🐛 Koenig - Fixed /-menu not working after the editor is reloaded

Browse source 
refs https://github.com/TryGhost/Ghost/issues/9724
- if the editor was reloaded by changing the post model either through clicking "New story" or using the search from the editor screen the /-menu would stop working
- keep track of the last seen `editor` instance inside `{{koenig-slash-menu}}` and register the `/` text input handler on the new editor instance if it changes
This commit is contained in:
Kevin Ansfield 2018-07-11 15:08:51 +01:00
parent 68ce5571f4
commit beab7a7a4f
1 changed files with 13 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
ghost/admin/lib/koenig-editor/addon/components/koenig-slash-menu.js
View file

@ -58,28 +58,27 @@ export default Component.extend({
return map; return map;
}), }),
init() { didReceiveAttrs() {
this._super(...arguments); this._super(...arguments);
let editor = this.editor;
// register `/` text input for positioning & showing the menu // re-register the / text input handler if the editor changes such as
editor.onTextInput({ // when a "New story" is clicked from the sidebar or a different post
// is loaded via search
if (this.editor !== this._lastEditor) {
this.editor.onTextInput({
name: 'slash_menu', name: 'slash_menu',
text: '/', text: '/',
run: run.bind(this, this._showMenu) run: run.bind(this, this._showMenu)
}); });
}, }
this._lastEditor = this.editor;
didReceiveAttrs() {
this._super(...arguments);
let editorRange = this.editorRange;
// re-position the menu and update the query if necessary when the // re-position the menu and update the query if necessary when the
// cursor position changes // cursor position changes
let editorRange = this.editorRange;
if (editorRange !== this._lastEditorRange) { if (editorRange !== this._lastEditorRange) {
this._handleCursorChange(editorRange); this._handleCursorChange(editorRange);
} }
this._lastEditorRange = editorRange; this._lastEditorRange = editorRange;
}, },