From bea04e437dc7ed6079380ed704b9c8f6ec565d75 Mon Sep 17 00:00:00 2001 From: Hannah Wolfe Date: Wed, 26 May 2021 14:57:43 +0100 Subject: [PATCH] Upgraded no-skipped-test rule to error refs: https://github.com/TryGhost/Ghost/commit/895bffec1fbc83234aa4a2e49abc0d687519f7bc - Allowing tests to be skipped masks issues where people temporarily skip tests to fix later and accidentally commit - Converting this to an error allows us to see when this happens easily - In future, when we're done with the dance of using ESLint rules to signpost codebase improvements, we may want to downgrade this back to a warning - This would enable us to have deliberate, temporarily skipped tests in the codebase, if there's a usecase for that with pushing to main regularly --- test/.eslintrc.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/.eslintrc.js b/test/.eslintrc.js index 1b371e0ce0..58d997cb01 100644 --- a/test/.eslintrc.js +++ b/test/.eslintrc.js @@ -23,7 +23,7 @@ module.exports = { 'no-unused-vars': 'off', 'no-useless-escape': 'off', - 'ghost/mocha/no-skipped-tests': 'warn', + 'ghost/mocha/no-skipped-tests': 'error', // TODO: remove these custom rules and fix problems in test files 'ghost/mocha/max-top-level-suites': 'off',