Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-27 22:49:56 -05:00
Code Issues Activity

Merge pull request #4781 from ErisDS/has-tag-fix

Browse source 
Fix has helper tag matching
This commit is contained in:
Jason Williams 2015-01-11 13:01:55 -06:00
commit be462d8d94
2 changed files with 27 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
core/server/helpers/has.js
View file

@ -25,7 +25,7 @@ has = function (options) {
return p || (_.findIndex(tags, function (item) { return p || (_.findIndex(tags, function (item) {
// Escape regex special characters // Escape regex special characters
item = item.replace(/[\-\/\\\^$*+?.()|\[\]{}]/g, '\\$&'); item = item.replace(/[\-\/\\\^$*+?.()|\[\]{}]/g, '\\$&');
item = new RegExp(item, 'i'); item = new RegExp('^' + item + '$', 'i');
return item.test(c); return item.test(c);
}) !== -1); }) !== -1);
}, false); }, false);

26
core/test/unit/server_helpers/has_spec.js
View file

@ -44,6 +44,32 @@ describe('{{#has}} helper', function () {
inverse.called.should.be.false; inverse.called.should.be.false;
}); });
it('should match exact tags, not superstrings', function () {
var fn = sinon.spy(),
inverse = sinon.spy();
helpers.has.call(
{tags: [{name: 'magical'}]},
{hash: {tag: 'magic'}, fn: fn, inverse: inverse}
);
fn.called.should.be.false;
inverse.called.should.be.true;
});
it('should match exact tags, not substrings', function () {
var fn = sinon.spy(),
inverse = sinon.spy();
helpers.has.call(
{tags: [{name: 'magic'}]},
{hash: {tag: 'magical'}, fn: fn, inverse: inverse}
);
fn.called.should.be.false;
inverse.called.should.be.true;
});
it('should handle tag list that validates false', function () { it('should handle tag list that validates false', function () {
var fn = sinon.spy(), var fn = sinon.spy(),
inverse = sinon.spy(); inverse = sinon.spy();