Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-06 22:40:14 -05:00
Code Issues Activity

🐛 Fixed wrong breadcrumb and missing post status when starting new post from analytics

Browse source 
closes https://linear.app/tryghost/issue/ENG-1533

- the code to switch to "from analytics" state for the editor was applying when clicking the create post button in the nav menu whilst on the analytics screen which was confusing because you not only lost the `< Posts` link in the editor but you couldn't see the post's saving status
This commit is contained in:
Kevin Ansfield 2024-09-19 16:21:44 +01:00
parent 46aa2a7ce7
commit bd6ca272dd
2 changed files with 18 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ghost/admin/app/routes/lexical-editor.js
View file

@ -17,7 +17,7 @@ export default AuthenticatedRoute.extend({
},
setupController(controller, model, transition) {
if (transition.from?.name === 'posts.analytics') {
if (transition.from?.name === 'posts.analytics' && transition.to?.name !== 'lexical-editor.new') {
controller.fromAnalytics = true;
}
},

17
ghost/admin/tests/acceptance/editor-test.js
View file

@ -606,6 +606,23 @@ describe('Acceptance: Editor', function () {
).to.equal(`/ghost/posts/analytics/${post.id}`);
});
it('does not render analytics breadcrumb for a new post', async function () {
const post = this.server.create('post', {
authors: [author],
status: 'published',
title: 'Published Post'
});
// visit the analytics page for the post
await visit(`/posts/analytics/${post.id}`);
// start a new post
await visit('/editor/post');
// Breadcrumbs should not contain Analytics link
expect(find('[data-test-breadcrumb]'), 'breadcrumb text').to.contain.text('Posts');
expect(find('[data-test-editor-post-status]')).to.contain.text('New');
});
it('handles TKs in title', async function () {
let post = this.server.create('post', {authors: [author]});