Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-24 23:48:13 -05:00
Code Issues Activity

Removed development option from feature helper (#2164)

Browse source 
no-issue

We now calculate whether or not a flag is enabled on the server, so this
extra check is redundant. It also means that when we promote a flag to
GA on the server this check will still take places, meaning that we need
to make two commits to promote a flag to GA.
This commit is contained in:
Fabien 'egg' O'Carroll 2021-12-02 12:34:35 +02:00 • committed by GitHub
parent baddf934c7
commit bd2f4bd829
1 changed files with 14 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
ghost/admin/app/services/feature.js
View file

@ -21,10 +21,6 @@ export function feature(name, options = {}) {
enabled = this.get(`labs.${name}`) || false; enabled = this.get(`labs.${name}`) || false;
} }
if (options.developer) {
enabled = enabled && this.get('config.enableDeveloperExperiments');
}
return enabled; return enabled;
}, },
set(key, value) { set(key, value) {
@ -52,22 +48,22 @@ export default Service.extend({
emailAnalytics: feature('emailAnalytics'), emailAnalytics: feature('emailAnalytics'),
nightShift: feature('nightShift', {user: true, onChange: '_setAdminTheme'}), nightShift: feature('nightShift', {user: true, onChange: '_setAdminTheme'}),
multipleProducts: feature('multipleProducts'), multipleProducts: feature('multipleProducts'),
oauthLogin: feature('oauthLogin', {developer: true}), oauthLogin: feature('oauthLogin'),
customThemeSettings: feature('customThemeSettings'), customThemeSettings: feature('customThemeSettings'),
membersActivity: feature('membersActivity', {developer: true}), membersActivity: feature('membersActivity'),
cardSettingsPanel: feature('cardSettingsPanel', {developer: true}), cardSettingsPanel: feature('cardSettingsPanel'),
membersAutoLogin: feature('membersAutoLogin', {developer: true}), membersAutoLogin: feature('membersAutoLogin'),
urlCache: feature('urlCache', {developer: true}), urlCache: feature('urlCache'),
mediaAPI: feature('mediaAPI', {developer: true}), mediaAPI: feature('mediaAPI'),
filesAPI: feature('filesAPI', {developer: true}), filesAPI: feature('filesAPI'),
calloutCard: feature('calloutCard', {developer: true}), calloutCard: feature('calloutCard'),
nftCard: feature('nftCard'), nftCard: feature('nftCard'),
accordionCard: feature('accordionCard', {developer: true}), accordionCard: feature('accordionCard'),
fileCard: feature('fileCard', {developer: true}), fileCard: feature('fileCard'),
audioCard: feature('audioCard', {developer: true}), audioCard: feature('audioCard'),
videoCard: feature('videoCard', {developer: true}), videoCard: feature('videoCard'),
productCard: feature('productCard', {developer: true}), productCard: feature('productCard'),
quoteStyles: feature('quoteStyles', {developer: true}), quoteStyles: feature('quoteStyles'),
_user: null, _user: null,