From bc18aee3b41b971a2622794449c470e0659375d7 Mon Sep 17 00:00:00 2001 From: Kevin Ansfield Date: Mon, 2 Sep 2019 16:58:06 +0100 Subject: [PATCH] Removed unused admin serviceworker endpoint no issue - Ghost-Admin serviceworker support was removed a long time ago but the URL handling was never removed --- core/server/web/admin/app.js | 3 --- core/server/web/admin/serviceworker.js | 15 --------------- 2 files changed, 18 deletions(-) delete mode 100644 core/server/web/admin/serviceworker.js diff --git a/core/server/web/admin/app.js b/core/server/web/admin/app.js index 6af8258105..7bb0a28788 100644 --- a/core/server/web/admin/app.js +++ b/core/server/web/admin/app.js @@ -19,9 +19,6 @@ module.exports = function setupAdminApp() { {maxAge: (configMaxAge || configMaxAge === 0) ? configMaxAge : constants.ONE_YEAR_MS, fallthrough: false} )); - // Service Worker for offline support - adminApp.get(/^\/(sw.js|sw-registration.js)$/, require('./serviceworker')); - // Ember CLI's live-reload script if (config.get('env') === 'development') { adminApp.get('/ember-cli-live-reload.js', function emberLiveReload(req, res) { diff --git a/core/server/web/admin/serviceworker.js b/core/server/web/admin/serviceworker.js deleted file mode 100644 index 22d43e817e..0000000000 --- a/core/server/web/admin/serviceworker.js +++ /dev/null @@ -1,15 +0,0 @@ -const debug = require('ghost-ignition').debug('web:admin:serviceworker'); -const path = require('path'); - -// Route: index -// Path: /ghost/sw.js|sw-registration.js -// Method: GET -module.exports = function adminController(req, res) { - debug('serviceworker called'); - - const sw = path.join(__dirname, '..', '..', '..', 'built', 'assets', 'sw.js'), - swr = path.join(__dirname, '..', '..', '..', 'built', 'assets', 'sw-registration.js'), - fileToSend = req.url === '/sw.js' ? sw : swr; - - res.sendFile(fileToSend); -};