0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-10 23:36:14 -05:00

Simplified + unified debug naming conventions

- Reduced the number of levels in our debug naming in the frontend
- Unified components like "themes" and "routing" under one name
- Should help to make debug slightly more useful again
This commit is contained in:
Hannah Wolfe 2021-07-06 11:02:37 +01:00
parent bc5f6ed3cc
commit bab5764179
No known key found for this signature in database
GPG key ID: 9F8C7532D0A6BA55
14 changed files with 22 additions and 15 deletions

View file

@ -8,6 +8,8 @@
*
* This file is a great place for all the cross-component event handling in lieu of refactoring
*/
const debug = require('@tryghost/debug')('bridge');
const errors = require('@tryghost/errors');
const config = require('./shared/config');
const logging = require('@tryghost/logging');
@ -73,6 +75,7 @@ class Bridge {
reloadFrontend() {
const apiVersion = this.getFrontendApiVersion();
debug('reload frontend', apiVersion);
const siteApp = require('./server/web/site/app');
siteApp.reload({apiVersion});
}

View file

@ -1,4 +1,4 @@
const debug = require('@tryghost/debug')('services:routing:collection-router');
const debug = require('@tryghost/debug')('routing:collection-router');
const events = require('../../../server/lib/common/events');
const urlUtils = require('../../../shared/url-utils');
const ParentRouter = require('./ParentRouter');

View file

@ -7,7 +7,7 @@
* Only allows for .use and .get at the moment - we don't have clear use-cases for anything else yet.
*/
const debug = require('@tryghost/debug')('services:routing:ParentRouter');
const debug = require('@tryghost/debug')('routing:parent-router');
const EventEmitter = require('events').EventEmitter;
const express = require('../../../shared/express');

View file

@ -1,4 +1,4 @@
const debug = require('@tryghost/debug')('services:routing:static-pages-router');
const debug = require('@tryghost/debug')('routing:static-pages-router');
const urlUtils = require('../../../shared/url-utils');
const ParentRouter = require('./ParentRouter');
const controllers = require('./controllers');

View file

@ -1,4 +1,4 @@
const debug = require('@tryghost/debug')('services:routing:static-routes-router');
const debug = require('@tryghost/debug')('routing:static-routes-router');
const events = require('../../../server/lib/common/events');
const errors = require('@tryghost/errors');
const urlUtils = require('../../../shared/url-utils');

View file

@ -1,4 +1,4 @@
const debug = require('@tryghost/debug')('services:routing:taxonomy-router');
const debug = require('@tryghost/debug')('routing:taxonomy-router');
const config = require('../../../shared/config');
const events = require('../../../server/lib/common/events');
const ParentRouter = require('./ParentRouter');

View file

@ -1,4 +1,4 @@
const debug = require('@tryghost/debug')('services:routing:bootstrap');
const debug = require('@tryghost/debug')('routing');
const _ = require('lodash');
const events = require('../../../server/lib/common/events');
const frontendSettings = require('../settings');
@ -28,7 +28,7 @@ let siteRouter;
* @returns {ExpressRouter}
*/
module.exports.init = (options = {start: false}) => {
debug('bootstrap');
debug('bootstrap init', options);
registry.resetAllRouters();
registry.resetAllRoutes();
@ -65,6 +65,7 @@ module.exports.init = (options = {start: false}) => {
* @param {object} dynamicRoutes
*/
module.exports.start = (apiVersion, dynamicRoutes) => {
debug('bootstrap start', apiVersion, dynamicRoutes);
const RESOURCE_CONFIG = require(`./config/${apiVersion}`);
const unsubscribeRouter = new UnsubscribeRouter();

View file

@ -1,4 +1,4 @@
const debug = require('@tryghost/debug')('themes:loader');
const debug = require('@tryghost/debug')('themes');
const config = require('../../../shared/config');
const packageJSON = require('@tryghost/package-json');
const themeList = require('./list');

View file

@ -1,3 +1,4 @@
const debug = require('@tryghost/debug')('themes');
const fs = require('fs-extra');
const bridge = require('../../../bridge');
@ -11,7 +12,7 @@ const settingsCache = require('../../../shared/settings-cache');
const i18n = require('../../../shared/i18n');
const logging = require('@tryghost/logging');
const errors = require('@tryghost/errors');
const debug = require('@tryghost/debug')('api:themes');
const ObjectID = require('bson-objectid');
let themeStorage;

View file

@ -1,4 +1,4 @@
const debug = require('@tryghost/debug')('theme:validate');
const debug = require('@tryghost/debug')('themes');
const _ = require('lodash');
const Promise = require('bluebird');
const fs = require('fs-extra');

View file

@ -1,4 +1,4 @@
const debug = require('@tryghost/debug')('web:members:app');
const debug = require('@tryghost/debug')('members');
const {URL} = require('url');
const cors = require('cors');
const bodyParser = require('body-parser');

View file

@ -1,4 +1,4 @@
const debug = require('@tryghost/debug')('web:frontend');
const debug = require('@tryghost/debug')('frontend');
const express = require('../../../shared/express');
const shared = require('../shared');
@ -9,7 +9,7 @@ const shared = require('../shared');
* @returns {import('express').RequestHandler}
*/
module.exports = (options) => {
debug('FrontendApp setup start');
debug('FrontendApp setup start', options);
// FRONTEND
const frontendApp = express('frontend');

View file

@ -1,4 +1,4 @@
const debug = require('@tryghost/debug')('web:site:app');
const debug = require('@tryghost/debug')('frontend');
const path = require('path');
const express = require('../../../shared/express');
const cors = require('cors');
@ -73,7 +73,7 @@ function SiteRouter(req, res, next) {
}
module.exports = function setupSiteApp(options = {}) {
debug('Site setup start');
debug('Site setup start', options);
const siteApp = express('site');

View file

@ -1,5 +1,7 @@
const debug = require('@tryghost/debug')('routing');
const routing = require('../../../frontend/services/routing');
module.exports = function siteRoutes(options = {}) {
debug('site Routes', options);
return routing.bootstrap.init(options);
};