Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-04-08 02:52:39 -05:00
Code Issues Activity

Added bulk destroy options (#14870)

Browse source 
refs https://ghost.slack.com/archives/C02G9E68C/p1652980792270029

- When bulk unsubscribing members, the number of deleted newsletter relations are returned instead of the number of members with newsletters that were cleared
- This commit adds options to the bulk destroy methods.
- You can pass the column on which you want to delete rows in a bulk destroy operation via the `column` option.

Required for https://github.com/TryGhost/Members/pull/400
This commit is contained in:
Simon Backx 2022-05-20 12:24:36 +02:00 • committed by GitHub
parent fd8ce6a5bf
commit b9e520c657
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 14 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
core/server/models/base/plugins/bulk-operations.js
View file

@ -52,9 +52,9 @@ async function editMultiple(knex, table, chunk, options) {
await knex(table).whereIn('id', chunk).update(options.data);
}
async function delSingle(knex, table, id) {
async function delSingle(knex, table, id, options) {
try {
await knex(table).where('id', id).del();
await knex(table).where(options.column ?? 'id', id).del();
} catch (err) {
const importError = new errors.DataImportError({
message: `Failed to remove entry from ${table}`,
@ -66,8 +66,8 @@ async function delSingle(knex, table, id) {
}
}
async function delMultiple(knex, table, chunk) {
await knex(table).whereIn('id', chunk).del();
async function delMultiple(knex, table, chunk, options) {
await knex(table).whereIn(options.column ?? 'id', chunk).del();
}
const insert = createBulkOperation(insertSingle, insertMultiple);
@ -91,10 +91,18 @@ module.exports = function (Bookshelf) {
return edit(Bookshelf.knex, tableName, data, options);
},
bulkDestroy: function bulkDestroy(data, tableName) {
/**
*
* @param {string[]} data List of ids to delete
* @param {*} tableName
* @param {Object} [options]
* @param {string} [options.column] Delete the rows where this column equals the ids in `data` (defaults to 'id')
* @returns
*/
bulkDestroy: function bulkDestroy(data, tableName, options = {}) {
tableName = tableName || this.prototype.tableName;
return del(Bookshelf.knex, tableName, data);
return del(Bookshelf.knex, tableName, data, options);
}
});
};