From b99cf1675365ec87528e2db31300513c15c69860 Mon Sep 17 00:00:00 2001 From: Peter Zimon Date: Thu, 25 May 2023 17:12:35 +0200 Subject: [PATCH] Handle no-change saves in AdminX refs. https://github.com/TryGhost/Team/issues/3150 --- ghost/admin-x-settings/src/admin-x-ds/global/Modal.tsx | 2 +- ghost/admin-x-settings/src/hooks/useSettingGroup.tsx | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/ghost/admin-x-settings/src/admin-x-ds/global/Modal.tsx b/ghost/admin-x-settings/src/admin-x-ds/global/Modal.tsx index 8d4a2e5555..90047d56d8 100644 --- a/ghost/admin-x-settings/src/admin-x-ds/global/Modal.tsx +++ b/ghost/admin-x-settings/src/admin-x-ds/global/Modal.tsx @@ -42,7 +42,7 @@ const Modal: React.FC = ({size = 'md', title, okLabel, cancelLabel, }); } - let modalStyles = 'relative z-50 mx-auto flex flex-col justify-between bg-white shadow-xl w-full'; + let modalStyles = 'relative rounded overflow-hidden z-50 mx-auto flex flex-col justify-between bg-white shadow-xl w-full'; let backdropStyles = 'fixed inset-0 h-[100vh] w-[100vw] overflow-y-scroll '; switch (size) { diff --git a/ghost/admin-x-settings/src/hooks/useSettingGroup.tsx b/ghost/admin-x-settings/src/hooks/useSettingGroup.tsx index 5d25ca7479..3f36238a16 100644 --- a/ghost/admin-x-settings/src/hooks/useSettingGroup.tsx +++ b/ghost/admin-x-settings/src/hooks/useSettingGroup.tsx @@ -82,7 +82,9 @@ const useSettingGroup = (): SettingGroupHook => { value: setting.value }; }); - saveSettings?.(changedSettings); + if (changedSettings.length) { + saveSettings?.(changedSettings); + } setCurrentState('view'); };