From b91f3071be893c7092541855c023a34a496f5d02 Mon Sep 17 00:00:00 2001 From: Daniel Lockyer Date: Wed, 6 Nov 2019 08:31:11 +0700 Subject: [PATCH] Deferred loading metascraper (#11337) no issue - reduces Ghost boot time from 1.47s to 1.33s on my machine. --- core/server/api/canary/oembed.js | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/core/server/api/canary/oembed.js b/core/server/api/canary/oembed.js index 31ce26c494..59f3bbc780 100644 --- a/core/server/api/canary/oembed.js +++ b/core/server/api/canary/oembed.js @@ -3,18 +3,19 @@ const {extract, hasProvider} = require('oembed-parser'); const Promise = require('bluebird'); const request = require('../../lib/request'); const cheerio = require('cheerio'); -const metascraper = require('metascraper')([ - require('metascraper-url')(), - require('metascraper-title')(), - require('metascraper-description')(), - require('metascraper-author')(), - require('metascraper-publisher')(), - require('metascraper-image')(), - require('metascraper-logo-favicon')(), - require('metascraper-logo')() -]); async function fetchBookmarkData(url, html) { + const metascraper = require('metascraper')([ + require('metascraper-url')(), + require('metascraper-title')(), + require('metascraper-description')(), + require('metascraper-author')(), + require('metascraper-publisher')(), + require('metascraper-image')(), + require('metascraper-logo-favicon')(), + require('metascraper-logo')() + ]); + if (!html) { const response = await request(url, { headers: {