Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-24 23:48:13 -05:00
Code Issues Activity

ESLint: Be explicit with Ember Data attribute types

Browse source 
no issue
- https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/no-empty-attrs.md
This commit is contained in:
Kevin Ansfield 2018-01-11 09:29:42 +00:00
parent fda94fedab
commit b6ae61c22f
4 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ghost/admin/app/models/post.js
View file

@ -101,7 +101,7 @@ export default Model.extend(Comparable, ValidationEngine, {
status: attr('string', {defaultValue: 'draft'}), status: attr('string', {defaultValue: 'draft'}),
title: attr('string', {defaultValue: ''}), title: attr('string', {defaultValue: ''}),
updatedAtUTC: attr('moment-utc'), updatedAtUTC: attr('moment-utc'),
updatedBy: attr(), updatedBy: attr('number'),
url: attr('string'), url: attr('string'),
uuid: attr('string'), uuid: attr('string'),

4
ghost/admin/app/models/role.js
View file

@ -8,8 +8,8 @@ export default Model.extend({
description: attr('string'), description: attr('string'),
createdAtUTC: attr('moment-utc'), createdAtUTC: attr('moment-utc'),
updatedAtUTC: attr('moment-utc'), updatedAtUTC: attr('moment-utc'),
createdBy: attr(), createdBy: attr('number'),
updatedBy: attr(), updatedBy: attr('number'),
lowerCaseName: computed('name', function () { lowerCaseName: computed('name', function () {
return this.get('name').toLocaleLowerCase(); return this.get('name').toLocaleLowerCase();

6
ghost/admin/app/models/tag.js
View file

@ -11,15 +11,15 @@ export default Model.extend(ValidationEngine, {
name: attr('string'), name: attr('string'),
slug: attr('string'), slug: attr('string'),
description: attr('string'), description: attr('string'),
parent: attr(), parent: attr('string'), // unused
metaTitle: attr('string'), metaTitle: attr('string'),
metaDescription: attr('string'), metaDescription: attr('string'),
featureImage: attr('string'), featureImage: attr('string'),
visibility: attr('string', {defaultValue: 'public'}), visibility: attr('string', {defaultValue: 'public'}),
createdAtUTC: attr('moment-utc'), createdAtUTC: attr('moment-utc'),
updatedAtUTC: attr('moment-utc'), updatedAtUTC: attr('moment-utc'),
createdBy: attr(), createdBy: attr('number'),
updatedBy: attr(), updatedBy: attr('number'),
count: attr('raw'), count: attr('raw'),
isInternal: equal('visibility', 'internal'), isInternal: equal('visibility', 'internal'),

2
ghost/admin/mirage/factories/user.js
View file

@ -17,7 +17,7 @@ export default Factory.extend({
status: 'active', status: 'active',
tour: null, tour: null,
updatedAt: '2015-11-02T16:12:05.000Z', updatedAt: '2015-11-02T16:12:05.000Z',
updatedBy: '2015-09-02T13:41:50.000Z', updatedBy: '1',
website: 'http://example.com', website: 'http://example.com',
roles() { return []; } roles() { return []; }
}); });