Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-27 22:49:56 -05:00
Code Issues Activity

Fixed "Cannot read properties of null (reading 'off')" noise in tests (#18610)

Browse source 
no issue

- the lexical multiplayer experiment was causing noise in e2e tests because it tried to use `ghostServer.httpServer` which doesn't exist
This commit is contained in:
Kevin Ansfield 2023-10-13 12:46:24 +01:00 • committed by GitHub
parent 4815aa6e7f
commit b6216586c4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ghost/core/core/server/services/lexical-multiplayer/service.js
View file

@ -93,7 +93,7 @@ module.exports = {
_disable = async () => {
logging.info('Stopping lexical multiplayer websockets service');
ghostServer.httpServer.off('upgrade', handleUpgrade);
ghostServer.httpServer?.off('upgrade', handleUpgrade);
if (wss) {
_isClosing = true;