From b5d30661166f956a7726db049123171721099185 Mon Sep 17 00:00:00 2001 From: Daniel Lockyer Date: Fri, 16 Jun 2023 11:52:16 +0200 Subject: [PATCH] Removed `eslint-plugin-react` dependency from signup-form refs https://github.com/TryGhost/Ghost/commit/997cd3687e41c28593b3a25c9b5613f2a01e3f3f - the `eslint-config-react-app` dependency already covers all necessary rules from `eslint-plugin-react` and using it separately causes conflicts across projects in eslint config - thanks for the commit message @rishabhgrg :) --- ghost/signup-form/.eslintrc.cjs | 3 +-- ghost/signup-form/package.json | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/ghost/signup-form/.eslintrc.cjs b/ghost/signup-form/.eslintrc.cjs index 5e6629063e..0f6166bbd5 100644 --- a/ghost/signup-form/.eslintrc.cjs +++ b/ghost/signup-form/.eslintrc.cjs @@ -3,8 +3,7 @@ module.exports = { root: true, extends: [ 'react-app', - 'plugin:ghost/browser', - 'plugin:react/recommended' + 'plugin:ghost/browser' ], plugins: [ 'ghost', diff --git a/ghost/signup-form/package.json b/ghost/signup-form/package.json index 94322eb8cd..6b4c74955c 100644 --- a/ghost/signup-form/package.json +++ b/ghost/signup-form/package.json @@ -59,7 +59,6 @@ "eslint": "8.38.0", "eslint-config-react-app": "7.0.1", "eslint-plugin-ghost": "3.1.0", - "eslint-plugin-react": "7.32.2", "eslint-plugin-react-hooks": "4.6.0", "eslint-plugin-react-refresh": "0.3.4", "eslint-plugin-tailwindcss": "3.11.0",