From b5a7c92327e2f3e4313d9fb4c4d7c7c03f59e582 Mon Sep 17 00:00:00 2001 From: Rish Date: Fri, 22 Jan 2021 17:33:34 +0530 Subject: [PATCH] Removed `portal-action` param in favor of action no issue With Ghost 4.0, we want to keep a single universal action source so the Ghost core doesn't have to know about portal specific actions --- ghost/portal/src/components/Notification.js | 2 +- ghost/portal/src/utils/notifications.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ghost/portal/src/components/Notification.js b/ghost/portal/src/components/Notification.js index 35d1d959a1..28ee8db4e9 100644 --- a/ghost/portal/src/components/Notification.js +++ b/ghost/portal/src/components/Notification.js @@ -188,7 +188,7 @@ export default class Notification extends React.Component { const type = this.state.type; const deleteParams = []; if (['signin', 'signup'].includes(type)) { - deleteParams.push('portal-action', 'success'); + deleteParams.push('action', 'success'); } else if (['stripe:checkout'].includes(type)) { deleteParams.push('stripe'); } diff --git a/ghost/portal/src/utils/notifications.js b/ghost/portal/src/utils/notifications.js index d9d4a964b5..8ce05baf21 100644 --- a/ghost/portal/src/utils/notifications.js +++ b/ghost/portal/src/utils/notifications.js @@ -51,7 +51,7 @@ export default function NotificationParser({billingOnly = false} = {}) { return null; } const qsParams = new URLSearchParams(qs); - const action = qsParams.get('portal-action'); + const action = qsParams.get('action'); const successStatus = qsParams.get('success'); const stripeStatus = qsParams.get('stripe'); let notificationData = null;