Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-24 23:48:13 -05:00
Code Issues Activity

Cleanup posts template.

Browse source 
No issue.

* Fix indentation (it was surprisingly hard for me to grok what was happening
  without indentation).
* Utilize `alternateActive` from `core/client/utils/link-view.js` to
  maintain the `active` state. Observing `childViews` is deprecated (and
  may not work properly in future versions of Ember).
* Remove now unused `item-view`.
This commit is contained in:
Robert Jackson 2014-12-31 21:06:05 -05:00
parent d2bb1dd613
commit b56c26c597
3 changed files with 21 additions and 30 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ghost/admin/templates/posts.hbs
View file

@ -14,7 +14,7 @@
{{#view "paginated-scroll-box" tagName="section" classNames="content-list-content js-content-scrollbox"}} {{#view "paginated-scroll-box" tagName="section" classNames="content-list-content js-content-scrollbox"}}
<ol class="posts-list"> <ol class="posts-list">
{{#each post in model itemController="posts/post" itemView="post-item-view" itemTagName="li"}} {{#each post in model itemController="posts/post" itemView="post-item-view" itemTagName="li"}}
{{#link-to "posts.post" post class="permalink" title="Edit this post"}} {{#link-to "posts.post" post class="permalink" alternateActive=view.active title="Edit this post"}}
<h3 class="entry-title">{{post.title}}</h3> <h3 class="entry-title">{{post.title}}</h3>
<section class="entry-meta"> <section class="entry-meta">
<span class="status"> <span class="status">

9
ghost/admin/views/item-view.js
View file

@ -1,9 +0,0 @@
var ItemView = Ember.View.extend({
classNameBindings: ['active'],
active: Ember.computed('childViews.firstObject.active', function () {
return this.get('childViews.firstObject.active');
})
});
export default ItemView;

6
ghost/admin/views/post-item-view.js
View file

@ -1,7 +1,7 @@
import itemView from 'ghost/views/item-view'; var PostItemView = Ember.View.extend({
classNameBindings: ['active', 'isFeatured:featured', 'isPage:page'],
var PostItemView = itemView.extend({ active: null,
classNameBindings: ['isFeatured:featured', 'isPage:page'],
isFeatured: Ember.computed.alias('controller.model.featured'), isFeatured: Ember.computed.alias('controller.model.featured'),