Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-24 23:48:13 -05:00
Code Issues Activity

🐛 Fixed HTML escaping of feature_image_caption in newsletters

Browse source 
no issue

feature_image_caption was escaped in the new email stability flow, while that should not happen (bold/underline/...).
This commit is contained in:
Simon Backx 2023-01-30 14:39:08 +01:00
parent 8a8bd60d1c
commit b50e3915ea
2 changed files with 15 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
ghost/core/test/integration/services/email-service/batch-sending.test.js
View file

@ -743,5 +743,19 @@ describe('Batch sending tests', function () {
});
});
describe('HTML-content', function () {
it('Does not HTML escape feature_image_caption', async function () {
const {html, plaintext} = await sendEmail({
feature_image: 'https://example.com/image.jpg',
feature_image_caption: 'Testing <b>feature image caption</b>'
});
// Check html contains text without escaping
assert.match(html, /Testing <b>feature image caption<\/b>/);
// Check plaintext version dropped the bold tag
assert.match(plaintext, /Testing feature image caption/);
});
});
// TODO: Replacement fallbacks
});

2
ghost/email-service/lib/email-templates/template.hbs
View file

@ -105,7 +105,7 @@
</tr>
{{#if post.feature_image_caption }}
<tr>
<td class="feature-image-caption" align="center">{{post.feature_image_caption}}</td>
<td class="feature-image-caption" align="center">{{{post.feature_image_caption}}}</td>
</tr>
{{/if}}
{{/if}}