Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-27 22:49:56 -05:00
Code Issues Activity

Removed duplicate calls to moment()

Browse source 
- the return type of `getLastModifiedForDatum` is a moment object, and
  we're just wrapping it again in another moment call
- moment is very heavy so we shouldn't do it unnecessarily
- this makes boot time 1% quicker of heavy sites
This commit is contained in:
Daniel Lockyer 2024-10-08 17:12:41 +01:00 • committed by Daniel Lockyer
parent f798955bc9
commit b49210f4dd
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
ghost/core/core/frontend/services/sitemap/BaseSiteMapGenerator.js
View file

@ -95,6 +95,9 @@ class BaseSiteMapGenerator {
this.lastModified = Date.now(); this.lastModified = Date.now();
} }
/**
* @returns {moment.Moment}
*/
getLastModifiedForDatum(datum) { getLastModifiedForDatum(datum) {
if (datum.updated_at || datum.published_at || datum.created_at) { if (datum.updated_at || datum.published_at || datum.created_at) {
const modifiedDate = datum.updated_at || datum.published_at || datum.created_at; const modifiedDate = datum.updated_at || datum.published_at || datum.created_at;
@ -126,7 +129,7 @@ class BaseSiteMapGenerator {
node = { node = {
url: [ url: [
{loc: url}, {loc: url},
{lastmod: moment(this.getLastModifiedForDatum(datum)).toISOString()} {lastmod: this.getLastModifiedForDatum(datum).toISOString()}
] ]
}; };