From b48cc49e5a499c456c2b7b316630b6f3b195a9ae Mon Sep 17 00:00:00 2001 From: Kevin Ansfield Date: Fri, 8 Sep 2023 15:24:05 +0100 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20Fixed=20broken=20"<=20Posts"=20a?= =?UTF-8?q?nd=20"Back=20to=20editor"=20links=20in=20beta=20editor=20(infin?= =?UTF-8?q?ite=20save=20loop)=20(#18042)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit refs https://github.com/TryGhost/Product/issues/3843 If you used relative URLs in the beta editor, when it came to leaving the editor you would get stuck due to an infinite save loop occurring in the background requiring a refresh to get back to a working state. - when saving relative URLs the server will convert them to absolute for consistency and to ensure URLs work in other situations such as emails, RSS, 3rd party editors, etc - although we get different data back from the server we don't overwrite the content in the editor with it as that would cause loss of changes since the save as well as loss of the cursor position - when leaving the editor we compare content from the last save revision with the current editor content to see if we need to save a new revision but if the server data has been modified with relative->absolute URLs then we'd enter an infinite loop because the content would never match - relative->absolute URLs should be the only thing to ever be modified in the underlying data when saving so we can work around the issue by replacing each instance of the site's URL before comparing revision data to current data --- ghost/admin/app/controllers/lexical-editor.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ghost/admin/app/controllers/lexical-editor.js b/ghost/admin/app/controllers/lexical-editor.js index 8f31816e89..54f3dc0929 100644 --- a/ghost/admin/app/controllers/lexical-editor.js +++ b/ghost/admin/app/controllers/lexical-editor.js @@ -969,7 +969,7 @@ export default class LexicalEditorController extends Controller { // Check if anything has changed since the last revision let postRevisions = post.get('postRevisions').toArray(); let latestRevision = postRevisions[postRevisions.length - 1]; - let hasChangedSinceLastRevision = !post.isNew && post.lexical !== latestRevision.lexical; + let hasChangedSinceLastRevision = !post.isNew && post.lexical.replaceAll(this.config.blogUrl, '') !== latestRevision.lexical.replaceAll(this.config.blogUrl, ''); let fromNewToEdit = this.router.currentRouteName === 'lexical-editor.new' && transition.targetName === 'lexical-editor.edit'