Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-03 23:00:14 -05:00
Code Issues Activity

Fixed invalid selector for data-members-newsletter attribute (#18039)

Browse source 
no refs

Fixed invalid selector for `data-members-newsletter` attribute
This commit is contained in:
Michael Barrett 2023-09-08 14:21:56 +01:00 • committed by GitHub
parent d9b36567ca
commit b472ffb39b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
apps/portal/src/data-attributes.js
View file

@ -23,7 +23,7 @@ export function formSubmitHandler({event, form, errorEl, siteUrl, submitHandler}
labels.push(labelInputs[i].value); labels.push(labelInputs[i].value);
} }
let newsletterInputs = event.target.querySelectorAll('input[type=hidden][data-members-newsletter], input[type=checkbox][data-members-newsletter]:checked, input[type=radio][data-members-newsletter]:selected') || []; let newsletterInputs = event.target.querySelectorAll('input[type=hidden][data-members-newsletter], input[type=checkbox][data-members-newsletter]:checked, input[type=radio][data-members-newsletter]:checked') || [];
for (let i = 0; i < newsletterInputs.length; ++i) { for (let i = 0; i < newsletterInputs.length; ++i) {
newsletters.push({id: newsletterInputs[i].value}); newsletters.push({id: newsletterInputs[i].value});
} }

2
apps/portal/src/tests/data-attributes.test.js
View file

@ -63,7 +63,7 @@ function getMockData({newsletterQuerySelectorResult = null} = {}) {
value: 'Gold' value: 'Gold'
}]; }];
} }
if (elem === 'input[type=hidden][data-members-newsletter], input[type=checkbox][data-members-newsletter]:checked, input[type=radio][data-members-newsletter]:selected' && newsletterQuerySelectorResult) { if (elem === 'input[type=hidden][data-members-newsletter], input[type=checkbox][data-members-newsletter]:checked, input[type=radio][data-members-newsletter]:checked' && newsletterQuerySelectorResult) {
return newsletterQuerySelectorResult; return newsletterQuerySelectorResult;
} }
} }