Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-06 22:40:14 -05:00
Code Issues Activity

Added settings for members 'free' price

Browse source 
refs https://github.com/TryGhost/Team/issues/637

The "free" price - when Members signup without using Stripe, should have
a name and description, so that it can be displayed in Portal in a
similar way to paid price's. As there is only ever one, and it is not a
fully fledged price, a setting makes more sense than a dedicated db
table.
This commit is contained in:
Fabien O'Carroll 2021-05-04 15:43:18 +01:00
parent a138586c83
commit b35f060bef
5 changed files with 15 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
core/server/data/schema/default-settings.json
View file

@ -304,6 +304,14 @@
"stripe_connect_account_id": {
"defaultValue": null,
"type": "string"
},
"members_free_price_name": {
"defaultValue": "Free",
"type": "string"
},
"members_free_price_description": {
"defaultValue": "",
"type": "string"
}
},
"portal": {

2
test/regression/api/canary/admin/settings_spec.js
View file

@ -43,6 +43,8 @@ const defaultSettingsKeyTypes = [
{key: 'members_reply_address', type: 'members'},
{key: 'members_paid_signup_redirect', type: 'members'},
{key: 'members_free_signup_redirect', type: 'members'},
{key: 'members_free_price_name', type: 'members'},
{key: 'members_free_price_description', type: 'members'},
{key: 'stripe_product_name', type: 'members'},
{key: 'stripe_plans', type: 'members'},
{key: 'stripe_secret_key', type: 'members'},

2
test/regression/api/v2/admin/settings_spec.js
View file

@ -38,6 +38,8 @@ const defaultSettingsKeyTypes = [
{key: 'members_reply_address', type: 'members'},
{key: 'members_paid_signup_redirect', type: 'members'},
{key: 'members_free_signup_redirect', type: 'members'},
{key: 'members_free_price_name', type: 'members'},
{key: 'members_free_price_description', type: 'members'},
{key: 'stripe_product_name', type: 'members'},
{key: 'stripe_plans', type: 'members'},
{key: 'stripe_secret_key', type: 'members'},

2
test/regression/api/v3/admin/settings_spec.js
View file

@ -41,6 +41,8 @@ const defaultSettingsKeyTypes = [
{key: 'members_reply_address', type: 'members'},
{key: 'members_paid_signup_redirect', type: 'members'},
{key: 'members_free_signup_redirect', type: 'members'},
{key: 'members_free_price_name', type: 'members'},
{key: 'members_free_price_description', type: 'members'},
{key: 'stripe_product_name', type: 'members'},
{key: 'stripe_plans', type: 'members'},
{key: 'stripe_secret_key', type: 'members'},

2
test/unit/data/schema/integrity_spec.js
View file

@ -34,7 +34,7 @@ describe('DB version integrity', function () {
// Only these variables should need updating
const currentSchemaHash = '7886f066821a240b85c6b61ba2dcff65';
const currentFixturesHash = '8671672598d2a62e53418c4b91aa79a3';
const currentSettingsHash = '5529b6fd5ee65b65bb78954fd721b248';
const currentSettingsHash = '1f41d1a0a21500bcaf2829288dff5a67';
const currentRoutesHash = '3d180d52c663d173a6be791ef411ed01';
// If this test is failing, then it is likely a change has been made that requires a DB version bump,