Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-06 22:40:14 -05:00
Code Issues Activity

Catch errors when rendering the error template

Browse source 
fixes #1991

- if there's an error when rendering the error template, default to sending a plain response detailing both errors.
This commit is contained in:
Hannah Wolfe 2014-01-23 17:52:18 +00:00
parent cccc19842e
commit b2e5ef4154
1 changed files with 19 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
core/server/errorHandling.js
View file

@ -5,6 +5,7 @@ var _ = require('underscore'),
configPaths = require('./config/paths'),
path = require('path'),
when = require('when'),
hbs = require('express-hbs'),
errors,
// Paths for views
@ -121,6 +122,8 @@ errors = {
renderErrorPage: function (code, err, req, res, next) {
/*jslint unparam:true*/
var self = this;
function parseStack(stack) {
if (!_.isString(stack)) {
return stack;
@ -158,16 +161,30 @@ errors = {
stack = parseStack(err.stack);
}
// TODO: Attach node-polyglot
res.status(code).render((errorView || 'error'), {
message: err.message || err,
code: code,
stack: stack
}, function (templateErr, html) {
if (!templateErr) {
return res.send(code, html);
}
// There was an error trying to render the error page, output the error
self.logError(templateErr, 'Error whilst rendering error page', 'Error template has an error');
// And then try to explain things to the user...
// Cheat and output the error using handlebars escapeExpression
return res.send(500, "<h1>Oops, seems there is an an error in the error template.</h1>"
+ "<p>Encountered the error: </p>"
+ "<pre>" + hbs.handlebars.Utils.escapeExpression(templateErr.message || templateErr) + "</pre>"
+ "<br ><p>whilst trying to render an error page for the error: </p>"
+ code + " " + "<pre>" + hbs.handlebars.Utils.escapeExpression(err.message || err) + "</pre>"
);
});
}
if (code >= 500) {
this.logError(err, "ErrorPage", "Ghost caught a processing error in the middleware layer.");
this.logError(err, "Rendering Error Page", "Ghost caught a processing error in the middleware layer.");
}
// Are we admin? If so, don't worry about the user template