From b2798fef96a462d5d580c09c6ea147aebffeb464 Mon Sep 17 00:00:00 2001 From: Kevin Ansfield Date: Wed, 22 Jul 2020 18:16:36 +0100 Subject: [PATCH] Removed mocha retries config no issue Retries can result in bogus error messages for any non-idempotent tests with multiple assertions, causing frustrating test debug experiences. An example: 1. Members import test runs 2. Import succeeds, count assertions pass, assertion for "import label" presence fails 3. Mocha re-runs the test 4. "Imported member" count assertions now fail because the importer won't import duplicates and the db is not cleared for each individual test for performance 5. Mocha reports a test failure as the imported count being incorrect rather than the missing label --- Gruntfile.js | 1 - 1 file changed, 1 deletion(-) diff --git a/Gruntfile.js b/Gruntfile.js index fb30a13548..bb6f99a18a 100644 --- a/Gruntfile.js +++ b/Gruntfile.js @@ -127,7 +127,6 @@ const configureGrunt = function (grunt) { reporter: grunt.option('reporter') || 'spec', timeout: '60000', require: ['core/server/overrides'], - retries: '3', exit: true },