Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-03 23:00:14 -05:00
Code Issues Activity

Added mailgun-client test to ensure config values are prioritised over settings

Browse source 
- this is the current functionality of the code, as it has always been,
  but this test ensures we prioritise the values in the config over
  those in settings
This commit is contained in:
Daniel Lockyer 2022-08-11 09:01:26 +02:00
parent f9b90a3cfe
commit b226065c04
No known key found for this signature in database
GPG key ID: D21186F0B47295AD
1 changed files with 36 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

36
ghost/mailgun-client/test/mailgun-client.test.js
View file

@ -87,6 +87,42 @@ describe('MailgunClient', function () {
assert.equal(eventsMock2.isDone(), true);
});
it('prioritises config values over settings', async function () {
const configStub = sinon.stub(config, 'get');
configStub.withArgs('bulkEmail').returns({
mailgun: {
apiKey: 'apiKey',
domain: 'configdomain.com',
baseUrl: 'https://configapi.com/v3'
}
});
const settingsStub = sinon.stub(settings, 'get');
settingsStub.withArgs('mailgun_api_key').returns('settingsApiKey');
settingsStub.withArgs('mailgun_domain').returns('settingsdomain.com');
settingsStub.withArgs('mailgun_base_url').returns('https://settingsapi.com/v3');
const configApiMock = nock('https://configapi.com')
.get('/v3/configdomain.com/events')
.query(MAILGUN_OPTIONS)
.reply(200, {'Content-Type': 'application/json'}, {
items: []
});
const settingsApiMock = nock('https://settingsapi.com')
.get('/v3/settingsdomain.com/events')
.query(MAILGUN_OPTIONS)
.reply(200, {'Content-Type': 'application/json'}, {
items: []
});
const mailgunClient = new MailgunClient({config, settings});
await mailgunClient.fetchEvents(MAILGUN_OPTIONS, () => {});
assert.equal(configApiMock.isDone(), true);
assert.equal(settingsApiMock.isDone(), false);
});
describe('send()', function () {
it('does not send if not configured', async function () {
const mailgunClient = new MailgunClient({config, settings});