From b16284f1edd62b7b99afd5a3c71fcc4636959b8b Mon Sep 17 00:00:00 2001 From: Robert Jackson Date: Tue, 5 May 2015 13:43:06 -0400 Subject: [PATCH] Replace gh-blog-url helper with a component. Accessing `this` inside an `Ember.HTMLBars.makeBoundHelper` will not always return the containing `view` object. Instead, use a component. --- core/client/app/components/gh-blog-url.js | 7 +++++++ core/client/app/helpers/gh-blog-url.js | 6 ------ core/client/app/templates/components/gh-blog-url.hbs | 1 + 3 files changed, 8 insertions(+), 6 deletions(-) create mode 100644 core/client/app/components/gh-blog-url.js delete mode 100644 core/client/app/helpers/gh-blog-url.js create mode 100644 core/client/app/templates/components/gh-blog-url.hbs diff --git a/core/client/app/components/gh-blog-url.js b/core/client/app/components/gh-blog-url.js new file mode 100644 index 0000000000..381911e341 --- /dev/null +++ b/core/client/app/components/gh-blog-url.js @@ -0,0 +1,7 @@ +import Ember from 'ember'; + +var blogUrl = Ember.Component.extend({ + tagName: '' +}); + +export default blogUrl; diff --git a/core/client/app/helpers/gh-blog-url.js b/core/client/app/helpers/gh-blog-url.js deleted file mode 100644 index 3158b000e6..0000000000 --- a/core/client/app/helpers/gh-blog-url.js +++ /dev/null @@ -1,6 +0,0 @@ -import Ember from 'ember'; -var blogUrl = Ember.HTMLBars.makeBoundHelper(function () { - return Ember.String.htmlSafe(this.get('config.blogUrl')); -}); - -export default blogUrl; diff --git a/core/client/app/templates/components/gh-blog-url.hbs b/core/client/app/templates/components/gh-blog-url.hbs new file mode 100644 index 0000000000..457738f620 --- /dev/null +++ b/core/client/app/templates/components/gh-blog-url.hbs @@ -0,0 +1 @@ +{{{config.blogUrl}}} \ No newline at end of file