From b0d778a5dc9f51d34f110e44d6b15cfc4c22ec25 Mon Sep 17 00:00:00 2001 From: Kevin Ansfield Date: Mon, 28 May 2018 16:54:16 +0100 Subject: [PATCH] Koenig - Fixed "set on destroyed object" error refs https://github.com/TryGhost/Ghost/issues/9623 - the `{{koenig-toolbar}} `didReceiveAttrs` hook was triggering an async action when the component was being destroyed so a guard is needed around the call to `set` in the `_hideToolbar` method --- .../lib/koenig-editor/addon/components/koenig-toolbar.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ghost/admin/lib/koenig-editor/addon/components/koenig-toolbar.js b/ghost/admin/lib/koenig-editor/addon/components/koenig-toolbar.js index 739eab6c00..0259cf61ea 100644 --- a/ghost/admin/lib/koenig-editor/addon/components/koenig-toolbar.js +++ b/ghost/admin/lib/koenig-editor/addon/components/koenig-toolbar.js @@ -227,7 +227,9 @@ export default Component.extend({ }, _hideToolbar() { - this.set('showToolbar', false); + if (!this.isDestroyed || !this.isDestroying) { + this.set('showToolbar', false); + } this._lastRange = null; this._removeMousemoveHandler(); },