From b0af496c98bbbaa358501265773d8afd40842663 Mon Sep 17 00:00:00 2001 From: Hannah Wolfe Date: Mon, 26 Sep 2016 10:10:44 +0100 Subject: [PATCH] =?UTF-8?q?=F0=9F=92=84=20Ensure=20all=20middleware=20use?= =?UTF-8?q?=20named=20functions=20(#7434)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit no issue - anonymous functions are hard to debug in memory traces etc - having anonymous middleware functions makes it hard to inspect or debug the middleware stack (something I like to do) - these 2 are the only ones atm, including all 3rd party middleware --- core/server/middleware/maintenance.js | 2 +- core/server/middleware/validation/upload.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/core/server/middleware/maintenance.js b/core/server/middleware/maintenance.js index 743edc86cb..5b7a68baf7 100644 --- a/core/server/middleware/maintenance.js +++ b/core/server/middleware/maintenance.js @@ -2,7 +2,7 @@ var config = require('../config'), i18n = require('../i18n'), errors = require('../errors'); -module.exports = function (req, res, next) { +module.exports = function maintenance(req, res, next) { if (config.get('maintenance').enabled) { return next(new errors.Maintenance( i18n.t('errors.general.maintenance') diff --git a/core/server/middleware/validation/upload.js b/core/server/middleware/validation/upload.js index 469c781948..5ca643a097 100644 --- a/core/server/middleware/validation/upload.js +++ b/core/server/middleware/validation/upload.js @@ -7,7 +7,7 @@ module.exports = function upload(options) { var type = options.type; // if we finish the data/importer logic, we forward the request to the specified importer - return function (req, res, next) { + return function uploadValidation(req, res, next) { var extensions = (config.get('uploads')[type] && config.get('uploads')[type].extensions) || [], contentTypes = (config.get('uploads')[type] && config.get('uploads')[type].contentTypes) || [];