From ae4d15d2377b26747d60bf3d8abf7348589cacd0 Mon Sep 17 00:00:00 2001 From: Kevin Ansfield Date: Mon, 29 Mar 2021 10:32:03 +0100 Subject: [PATCH] Removed empty init() calls no issue - `init()` methods that do nothing but call `super()` aren't adding anything but add noise to class/object definitions --- ghost/admin/app/components/modal-invite-new-user.js | 4 ---- ghost/admin/app/components/modal-members-label-form.js | 4 ---- ghost/admin/app/controllers/settings/general.js | 4 ---- ghost/admin/app/controllers/settings/members-email.js | 4 ---- ghost/admin/app/controllers/settings/members-payments.js | 4 ---- 5 files changed, 20 deletions(-) diff --git a/ghost/admin/app/components/modal-invite-new-user.js b/ghost/admin/app/components/modal-invite-new-user.js index e207b039a9..a9b2ba8ad5 100644 --- a/ghost/admin/app/components/modal-invite-new-user.js +++ b/ghost/admin/app/components/modal-invite-new-user.js @@ -19,10 +19,6 @@ export default ModalComponent.extend(ValidationEngine, { validationType: 'inviteUser', - init() { - this._super(...arguments); - }, - didInsertElement() { this._super(...arguments); this.fetchRoles.perform(); diff --git a/ghost/admin/app/components/modal-members-label-form.js b/ghost/admin/app/components/modal-members-label-form.js index 08cb6e7230..16155b226f 100644 --- a/ghost/admin/app/components/modal-members-label-form.js +++ b/ghost/admin/app/components/modal-members-label-form.js @@ -13,10 +13,6 @@ export default ModalComponent.extend({ confirm() {}, label: computed.and('model', 'model.label'), - init() { - this._super(...arguments); - }, - willDestroyElement() { this._super(...arguments); this.label.errors.clear(); diff --git a/ghost/admin/app/controllers/settings/general.js b/ghost/admin/app/controllers/settings/general.js index cf9a48b7d1..3a3b6a24b8 100644 --- a/ghost/admin/app/controllers/settings/general.js +++ b/ghost/admin/app/controllers/settings/general.js @@ -32,10 +32,6 @@ export default Controller.extend({ _scratchFacebook: null, _scratchTwitter: null, - init() { - this._super(...arguments); - }, - privateRSSUrl: computed('config.blogUrl', 'settings.publicHash', function () { let blogUrl = this.get('config.blogUrl'); let publicHash = this.get('settings.publicHash'); diff --git a/ghost/admin/app/controllers/settings/members-email.js b/ghost/admin/app/controllers/settings/members-email.js index 884872fb76..d5b1cab556 100644 --- a/ghost/admin/app/controllers/settings/members-email.js +++ b/ghost/admin/app/controllers/settings/members-email.js @@ -30,10 +30,6 @@ export default Controller.extend({ yamlAccept: null, - init() { - this._super(...arguments); - }, - fromAddress: computed(function () { return this.parseEmailAddress(this.settings.get('membersFromAddress')); }), diff --git a/ghost/admin/app/controllers/settings/members-payments.js b/ghost/admin/app/controllers/settings/members-payments.js index 050d2a4e47..e6e1cad3bf 100644 --- a/ghost/admin/app/controllers/settings/members-payments.js +++ b/ghost/admin/app/controllers/settings/members-payments.js @@ -27,10 +27,6 @@ export default Controller.extend({ yamlAccept: null, - init() { - this._super(...arguments); - }, - blogDomain: computed('config.blogDomain', function () { let blogDomain = this.config.blogDomain || ''; const domainExp = blogDomain.replace('https://', '').replace('http://', '').match(new RegExp('^([^/:?#]+)(?:[/:?#]|$)', 'i'));